OECD_Waste_Water_Treatment cloud job fix - #2098
Merged
saanikaaa merged 18 commits intoAug 28, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new utility script merge_historical_data.py to reconcile and merge current wastewater treatment data with historical records, alongside adding validation configurations and golden datasets. Feedback on the script highlights critical improvements: normalizing key columns to strings to prevent merge mismatches due to differing data types, filtering the merged DataFrame directly to avoid index alignment bugs, and utilizing file_util.FileIO to ensure reliable writing to Google Cloud Storage paths.
pulkeet-wq
reviewed
Jul 22, 2026
Contributor
|
LGTM |
ajaits
reviewed
Aug 6, 2026
ajaits
reviewed
Aug 6, 2026
saanikaaa
changed the title
rohitkumarbhagat
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is raised to fix OECD_Waste_Water_Treatment import cloud job which was failing due to deletions and also to add the golden test for the same.
The auto-refresh job was failing due to 1.77% (~130) deleted records, which triggered a validation error. Verified against the source that deletions are as per source itself. More details with attached screenshot can be found here.
As discussed and aligned with core team, we have increased the threshold to 2% for the import to pass.
SOP: Link
PR_CHECKLIST: Link