fix: apply the server override options downstream of the connection - #1525
Merged
Conversation
Options such as DATACONTRACT_BIGQUERY_PROJECT and DATACONTRACT_POSTGRES_SCHEMA were applied only in connect.py, so the table lookup and the catalog reads behind physical type checks still used the contract's location. Resolve the effective server once, where it enters the run, and log a displaced value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DATACONTRACT_*options that override a server's location (DATACONTRACT_BIGQUERY_PROJECT,DATACONTRACT_POSTGRES_SCHEMA, and the like) now also apply to the table lookup and the physical type checks, not just to the connection. Adds the missing duckdb options.