Honor physicalName in Avro and JSON Schema exports - #1527
Open
henriquejsza wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
physicalNamewith anamefallback for Avro schemas, records, fields, and enum namesrequired, and pattern properties aligned with physical namesValidation
uv run pytest -n0 tests/test_export_avro.py tests/test_export_jsonschema.py tests/test_roundtrip_jsonschema.py(18 passed)uv run pytest -n0(2,110 passed, 14 skipped, 1 xfailed; Docker-dependent container files were not collected because no daemon was available)uv run ruff checkuv run ruff format --checkuv run python lint_examples.py(12/12)uv run pre-commit run --all-filesuv build --wheeland CLI smoke exports for Avro and JSON SchemaTests pass (
uv run pytest)Code formatted (
uv run ruff check --fix && uv run ruff format)Docs updated (not required for this behavior fix)
CHANGELOG.md entry added
Fixes #1494