Keep onboarding to one model attempt and Tool counts to one turn - #1002
Merged
Conversation
Synthetic onboarding now makes one primary provider attempt, exposes no wait tool, skips fallback and model-authored repair, and bypasses the semantic completion gate after deterministic checks pass. Direct Chat analysis cards count only Tool rows inside their user-turn group instead of substituting the Session aggregate. Constraint: Ordinary chat Runs retain their existing retry, fallback, repair, and semantic completion behavior. Rejected: Hide the stop button while onboarding remains active | would conceal a genuinely cancellable durable Run without fixing its repeated work. Rejected: Recompute per-turn counts in the backend Session list | the frontend already loads complete folded Tool turns and owns the user-turn grouping boundary. Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep onboarding_target_phase as the explicit boundary for single-attempt behavior; do not infer it from empty visible history. Tested: 179 backend tests; 122 frontend tests; frontend production build; scoped Ruff; Architecture Guard P0; git diff --check. Not-tested: Live onboarding against the production provider and browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Release
v1.11.4-fix.1from the resulting main commit. The prior GitHub Release is deleted; the old remote tag will be removed only after this PR is merged.