[Port to dtq-dev] Issue 1406: normalize metadatavalue.text_lang = '*' to NULL - #1412
Open
kosarko wants to merge 1 commit into
Open
[Port to dtq-dev] Issue 1406: normalize metadatavalue.text_lang = '*' to NULL#1412kosarko wants to merge 1 commit into
kosarko wants to merge 1 commit into
Conversation
Rows written before the 7.6.5 upgrade carry text_lang = '*' (Item.ANY). MetadataValue.setLanguage() normalizes '*' -> NULL since 7.6.5, so no new rows can be created, but nothing repaired the existing ones: the setter only runs on row creation. Stale '*' rows break the metadata-export -> metadata-import round trip (the export emits [*] headers the import rejects, #1402) and make OAI store <element name="*"/>, from which oai_openaire emits an invalid xml:lang="*". The migration bumps item.last_modified on the affected items before normalizing. That is what makes the reindex happen without a forced full rebuild: 'dspace oai import' and 'dspace index-discovery' both select items by last_modified, so the existing cron runs pick up exactly the touched items. Only '*' is normalized; empty-string languages are legal and round-trip correctly. (cherry picked from commit 442fae6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of ufal#1407 by @kosarko to
dtq-dev.