TUL/fix: default filter operator to 'equals' for operator-less search URLs (#781)

[milanmajchrak]

Problem

A search URL whose filter carries no operator — e.g. a legacy or crawled /search?f.subject=radiodiagnostika instead of f.subject=radiodiagnostika,equals — is forwarded to the backend verbatim. The backend correctly rejects the operator-less filter with HTTP 422 per the DSpace REST Contract, and because one search page fans out into ~6 discover sub-requests (search/objects + each facet), each affected render produces a burst of 422s (dataquest-dev/dspace-customers#781).

Today's UI always emits ,equals on facet links, so these operator-less URLs are legacy/bookmarked/crawled links from before the operator format.

Fix

In SearchConfigurationService.getCurrentFilters(), when building SearchFilters from the URL, default the operator to 'equals' — mirroring the existing range-filter (.min/.max) branch right above, which already passes 'equals'.

-  filters.push(new SearchFilter(key, filterParams[key]));
+  filters.push(new SearchFilter(key, filterParams[key], 'equals'));

This is safe because SearchOptions.toRestUrl only appends the operator when the value does not already contain a comma:

const filterValue = value.includes(',') ? `${value}` : value + (filter.operator ? ',' + filter.operator : '');

So values that already embed an operator (radiodiagnostika,equals, foo,notequals, id,authority, …) are left untouched; only truly operator-less values gain ,equals. Operator-less legacy URLs now resolve to <value>,equals and return results instead of 422.

Tests

Updated the getCurrentFilters expectations in search-configuration.service.spec.ts and my-dspace-configuration.service.spec.ts (the plain, non-range filter now carries operator: 'equals').

Companion

A backend PR (dataquest-dev/DSpace customer/TUL) downgrades any remaining discover 422 from ERROR to WARN so monitoring is not tripped even if an operator-less request slips through another path.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 59c1cd40-663b-4b9d-8377-8d820e2ba2b1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR aims to prevent legacy/crawled search URLs with operator-less filters (e.g. f.subject=foo) from being forwarded to the REST backend without an operator, which currently triggers HTTP 422 responses and cascades into multiple failing discover requests per page render.

Changes:

• Default non-range URL-derived SearchFilter operators to 'equals' in SearchConfigurationService.getCurrentFilters().
• Update unit test expectations so non-range filters created from URL params include operator: 'equals'.
• Keep range filter handling (.min/.max) unchanged (already uses 'equals').

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/app/core/shared/search/search-configuration.service.ts	Defaults operator to 'equals' when converting URL filter params to SearchFilters.
src/app/core/shared/search/search-configuration.service.spec.ts	Adjusts getCurrentFilters expectations for the default operator behavior.
src/app/my-dspace-page/my-dspace-configuration.service.spec.ts	Updates MyDSpace filter expectations to include the default operator.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.