JCU/Prevent an admin from deleting their own account

[Kasinhou]

Backport of the UFAL self-delete guard from dtq-dev onto customer/jcu — #1335 (the feature), #1357 (friendly rejection notification) and #1373 (tooltip clipped by the table).

What changes

• The EPeople registry and the EPerson form no longer offer delete for the currently authenticated user: the button renders disabled with a tooltip explaining why.
• Deleting a high-impact account now shows a contextual warning in the confirmation modal (submitter / administrator / both), via a new warningLabel input on ConfirmationModalComponent.
• If the backend still rejects a self-delete (400), the UI shows the friendly "you cannot delete your own account" notification instead of a generic failure.
• Shared logic lives in the new EPersonDeleteGuardService so the registry and the form stay in sync.
• New en/cs i18n keys for the notification and the three warnings.

Branch-specific notes
Translated (not cherry-picked): DSpace 9.3 uses standalone components and @if control flow, so there is no AccessControlModule to register the service in — EPersonDeleteGuardService is providedIn: 'root' here, and NgbTooltipModule + BtnDisabledDirective were added to the two components' imports.

Verified locally (Node 22): ng test --include='src/app/access-control/epeople-registry/**/*.spec.ts' and --include='src/app/shared/confirmation-modal/**/*.spec.ts' all green; eslint on the changed files reports 0 errors.

Backend counterpart: dataquest-dev/DSpace#1402 — the two must ship together.

Refs dataquest-dev/dspace-customers#855

---

How this was verified

Manual — on a live instance (JCU 9.3 pair)

Throwaway stack: backend built from the paired branch jcu/be-forbid-admin-self-delete (REST on :8091,
own DB / Solr), frontend served from the branch under test, logged in as an administrator.

	Result
Before (base branch)	The Delete button on the administrator's own row in Access Control → EPeople is enabled and clickable. Driving that same delete through the REST API returned 204 and the account was gone (404) — the bug in issue #855, reproduced.
After (this change)	The own row's Delete button is disabled and carries the tooltip "You cannot delete your own EPerson account.", rendered above the table without being clipped (the container="body" part of #1373).
Regression	Deleting a different EPerson still works end to end: confirmation modal → Delete → the row disappears.
Other rows	Unaffected — still enabled.

Automated

Locally on this branch (Node 22):
ng test --include='src/app/access-control/epeople-registry/**/*.spec.ts' → 44 tests, 0 failures;
--include='src/app/shared/confirmation-modal/**/*.spec.ts' → 11 tests, 0 failures;
eslint on the changed files → 0 errors.
The CI tests job runs lint plus the full unit suite on this PR.

This branch is the one exercised live above.

---

Follow-up after Copilot review

Copilot flagged that the else branch of the registry delete handler passed
notification.deleted.success to notificationsService.error(...), so any delete
failure other than a self-delete rendered a red toast reading "Successfully deleted
EPerson: """ — with an empty name, and with {{restResponse.errorMessage}} never
filled in.

Valid finding, and not a new idea: dtq-dev already fixes this in the very commit this
PR backports (07957d83b1, UFAL port of dspace-angular#1335). The hunk was missed when
the change was translated to the 9.x component. Fixed in a follow-up commit — the branch
now matches dtq-dev:

this.notificationsService.error(this.translateService.get(this.labelPrefix + 'notification.deleted.failure', {
  name: this.dsoNameService.getName(ePerson),
  id: ePerson.id,
  statusCode: restResponse.statusCode,
  errorMessage: restResponse.errorMessage,
  restResponse,
}));

Only the two 9.x branches (mendelu, jcu) needed this — the 7.6.1/7.6.5 branches took
the hunk whole during the cherry-pick and already used the failure key, and TUL (7.5)
never used the key at all (it builds the message inline). Unit tests re-run after the
change and still green.

Live UI screenshots

Captured live in a browser (9.3 FE against a matching DSpace 9.3 backend): logged in as an administrator, opened
Access Control → EPeople. The admin's own row is the first one.

Before — the own row's Delete button is enabled/clickable (the bug).

After — the own row's Delete button is disabled and shows the tooltip "You cannot delete your own EPerson account."; other rows stay enabled.

[Copilot]

Pull request overview

This PR backports a UI guard to prevent administrators from deleting their own EPerson account, while also improving the delete UX by adding contextual warnings to the confirmation modal and a friendly notification when the backend rejects self-deletion.

Changes:

• Disable Delete for the currently authenticated user in both the EPeople registry and EPerson form, with an explanatory tooltip.
• Add an optional warningLabel to ConfirmationModalComponent to show contextual high-impact delete warnings (submitter/admin/both).
• Centralize delete-related logic in the new EPersonDeleteGuardService, including self-delete detection and warning-label resolution.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/assets/i18n/en.json5	Adds new EN i18n keys for self-delete notification and contextual delete warnings.
src/assets/i18n/cs.json5	Adds corresponding CS i18n keys for self-delete notification and warnings.
src/app/shared/testing/auth-service.stub.ts	Extends auth stub with getAuthenticatedUserFromStore() for new call sites/tests.
src/app/shared/confirmation-modal/confirmation-modal.component.ts	Adds optional warningLabel input to support contextual warnings.
src/app/shared/confirmation-modal/confirmation-modal.component.html	Renders warning text when warningLabel is present.
src/app/access-control/epeople-registry/eperson-form/eperson-form.component.ts	Uses delete guard service; blocks self-delete and adds warning label to modal.
src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html	Disables self-delete button with tooltip (container="body") and prevents clicks.
src/app/access-control/epeople-registry/eperson-form/eperson-form.component.spec.ts	Adds tests for disabled self-delete button and “notify instead of modal” behavior.
src/app/access-control/epeople-registry/eperson-delete-guard.service.ts	New shared service for self-delete detection, warning label resolution, and notification.
src/app/access-control/epeople-registry/eperson-delete-guard.service.spec.ts	New unit tests for the delete guard service behavior and error-degradation.
src/app/access-control/epeople-registry/epeople-registry.component.ts	Integrates guard service in registry delete flow and adds current-user awareness.
src/app/access-control/epeople-registry/epeople-registry.component.spec.ts	Adds tests asserting disabled self-row delete and notification instead of modal.
src/app/access-control/epeople-registry/epeople-registry.component.html	Disables self-row delete button with tooltip and dsBtnDisabled.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[milanmajchrak]

Uživatelsky účet

[milanmajchrak]

Velmi tazko sa to cita