Update customers which runs playwright tests - #1449
Merged
Merged
Conversation
Append dtq-dev-9-base to the branch list in trigger-ui-tests.yml so the nightly job dispatches playwright-tests.yml for it alongside the customer/* branches. The awk parser emits "dtq-dev-9-base/" for a non-namespaced branch, so it cannot be picked up by the customer/ grep and is added explicitly. Also includes a pre-existing working-tree edit adding customer/sav to SKIP_BRANCHES. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Kasinhou
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the nightly workflow that dispatches playwright-tests.yml so it also runs UI tests for the non-namespaced branch dtq-dev-9-base, which is currently excluded by the customer-only branch discovery logic.
Changes:
- Appends
dtq-dev-9-baseto the discoveredcustomer/*branch list so it gets included in the nightly dispatch loop. - Modifies
SKIP_BRANCHESto includecustomer/sav(noted in the PR description as an unrelated edit).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The nightly
Trigger UI Tests for All Customer Branchesjob only dispatchesplaywright-tests.ymlforcustomer/*branches.dtq-dev-9-baseis not covered, so it never gets nightly UI-test runs.