Skip to content

Add the missing highway kernels #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-devulap wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add the missing highway kernels #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab62e9e
Implement min_f32, sum_f32, scale_f32, sub_f32, sub_scalar_f32, and h…
r-devulap Oct 13, 2026
d2ba427
Add unit tests for newly implemented native SIMD kernels
r-devulap Oct 13, 2026
0d31531
Generate Java FFM bindings for new native SIMD kernels
r-devulap Oct 13, 2026
282ce21
Update verify_native_lib.sh to check all exported native SIMD symbols
r-devulap Oct 13, 2026
faf23ce
Wire NativeVectorUtilSupport to new native SIMD operations
r-devulap Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions jvector-native/src/main/java/io/github/jbellis/jvector/vector/NativeVectorUtilSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ public void addInPlace(VectorFloat<?> v1, float value) {
NativeSimdOps.add_scalar_in_place_f32(((MemorySegmentVectorFloat) v1).get(), value, v1.length());
}

@Override
public void scale(VectorFloat<?> vector, float multiplier) {
NativeSimdOps.scale_f32(((MemorySegmentVectorFloat) vector).get(), multiplier, vector.length());
}

@Override
public void subInPlace(VectorFloat<?> v1, VectorFloat<?> v2) {
NativeSimdOps.sub_in_place_f32(((MemorySegmentVectorFloat) v1).get(), ((MemorySegmentVectorFloat) v2).get(), v1.length());
Expand All @@ -124,16 +129,61 @@ public void subInPlace(VectorFloat<?> vector, float value) {
NativeSimdOps.sub_scalar_in_place_f32(((MemorySegmentVectorFloat) vector).get(), value, vector.length());
}

@Override
public VectorFloat<?> sub(VectorFloat<?> a, VectorFloat<?> b) {
return sub(a, 0, b, 0, a.length());
}

@Override
public VectorFloat<?> sub(VectorFloat<?> a, float value) {
return sub(a, 0, value, a.length());
}

@Override
public VectorFloat<?> sub(VectorFloat<?> a, int aOffset, VectorFloat<?> b, int bOffset, int length) {
VectorFloat<?> res = VectorizationProvider.getInstance().getVectorTypeSupport().createFloatVector(length);
NativeSimdOps.sub_f32(
((MemorySegmentVectorFloat) a).get(), aOffset,
((MemorySegmentVectorFloat) b).get(), bOffset,
((MemorySegmentVectorFloat) res).get(), length);
return res;
}

@Override
public VectorFloat<?> sub(VectorFloat<?> a, int aOffset, float value, int length) {
VectorFloat<?> res = VectorizationProvider.getInstance().getVectorTypeSupport().createFloatVector(length);
NativeSimdOps.sub_scalar_f32(
((MemorySegmentVectorFloat) a).get(), aOffset,
value,
((MemorySegmentVectorFloat) res).get(), length);
return res;
}

@Override
public float max(VectorFloat<?> v) {
return NativeSimdOps.max_f32(((MemorySegmentVectorFloat) v).get(), v.length());
}

@Override
public float min(VectorFloat<?> v) {
return NativeSimdOps.min_f32(((MemorySegmentVectorFloat) v).get(), v.length());
}

@Override
public void minInPlace(VectorFloat<?> v1, VectorFloat<?> v2) {
NativeSimdOps.min_in_place_f32(((MemorySegmentVectorFloat) v1).get(), ((MemorySegmentVectorFloat) v2).get(), v1.length());
}

@Override
public float sum(VectorFloat<?> vector) {
return NativeSimdOps.sum_f32(((MemorySegmentVectorFloat) vector).get(), vector.length());
}

@Override
public int hammingDistance(long[] a, long[] b) {
return NativeSimdOps.hamming_distance(MemorySegment.ofArray(a), MemorySegment.ofArray(b), (long) a.length);
}

@Override
public float assembleAndSumPQ(
VectorFloat<?> codebookPartialSums,
Expand Down
Loading
Loading