Repository navigation
fix: typo bug in max point interpolation: instead of x() and y(), it uses y() twice - #3169
Merged
Merged
Conversation
The second index in the 3x3 neighbourhood access used p.y() for both row and column, making the lookup walk along a column instead of a row. The column index should be p.x().
Owner
|
Thanks @lippinj for catching this! I added regression tests for off-axis maxima and rectangular matrices, and updated the tracker reference score to match the corrected interpolation while keeping the existing tolerances. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second index in the 3x3 neighbourhood access used p.y() for both row and column, making the lookup walk along a column instead of a row. The column index should be p.x().