Repository navigation
fix: prevent integer overflow when computing oca stop time - #3174
Merged
Merged
Conversation
Adding a large max_runtime duration to steady_clock::now() can overflow on platforms where the clock epoch is large (observed on macOS with GCC), wrapping time_to_stop to a value in the past and causing an immediate early exit. Fix the computation site: clamp time_to_stop to time_point::max() if the addition would overflow, rather than capping the default duration.
Owner
|
Thanks @lippinj for catching the OCA deadline overflow. I verified the overflow case and timeout boundaries; this looks good as submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a large max_runtime duration to steady_clock::now() can overflow on platforms where the clock epoch is large (observed on macOS with GCC), wrapping time_to_stop to a value in the past and causing an immediate early exit.
When computing time_to_stop, use a saturating addition instead.