Repository navigation
fix: initialize assignments vector after resize in kkmeans - #3175
Merged
Merged
Conversation
resize() allocates but does not zero-initialize the vector, leaving assignments in an indeterminate state before the first iteration. Add an explicit fill to zero.
lippinj
commented
Oct 16, 2026
Author
There was a problem hiding this comment.
Without initialization, UB read here.
lippinj
changed the title
Discard old scratch labels before resizing and force every sample to count as newly assigned on the first iteration. Cover one-cluster training, repeated and resized training, imbalanced initial assignments, kernel centroids, and iteration budgets.
Owner
|
Thanks @lippinj for catching the uninitialized assignments. I changed the initial labels to an invalid cluster index so the first pass always recomputes the centers, including single-cluster and heavily imbalanced cases. I also discard the old scratch labels before resizing and added regression tests for repeated training and iteration limits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resize() allocates but does not zero-initialize the vector, leaving assignments in an indeterminate state before the first iteration. Add an explicit fill to zero.