Repository navigation
dbeaver/pro#10784 Add shared SSO API contracts - #11
Merged
alexander-skoblikov merged 6 commits intoOct 8, 2026
Merged
alexander-skoblikov merged 6 commits into
alexander-skoblikov merged 6 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds a shared SSO API module containing DTOs, client utilities, JWT/JWKS verification, token exchange, and browser handoff support.
Changes:
- Added and registered the SSO OSGi/Maven module.
- Added shared authorization, identity, token, handoff, JWKS, and error models.
- Added client integration tests and SSO protocol documentation.
| File | Description |
|---|---|
| README.md | Updated as part of this pull request. |
| apis/pom.xml | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/test/java/com/dbeaver/datadam/sso/api/client/DDSsoClientTest.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoTokenResponse.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoTokenRequest.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoPublicJwk.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoJwksResponse.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoIdentity.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoHandoffResponse.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoHandoffRequest.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoErrorResponse.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/model/DDSsoAuthorizeRequest.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/exception/DDSsoClientException.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/client/DDSsoClientConfig.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/src/main/java/com/dbeaver/datadam/sso/api/client/DDSsoClient.java | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/pom.xml | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/META-INF/MANIFEST.MF | Updated as part of this pull request. |
| apis/com.dbeaver.datadam.sso.api/build.properties | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Bundle-ActivationPolicy: lazy | ||
| Require-Bundle: org.jkiss.utils, | ||
| com.nimbusds.nimbus-jose-jwt;bundle-version="10.9.1" | ||
| Import-Package: com.google.gson.annotations, |
| @NotNull String issuer, | ||
| @Nullable String backchannelUrl, | ||
| @NotNull String clientId, | ||
| @NotNull String clientSecret, |
vkirst
previously approved these changes
Oct 5, 2026
labanovichttps
previously approved these changes
Oct 7, 2026
vkirst
approved these changes
Oct 8, 2026
alexander-skoblikov
deleted the
dbeaver/pro#10784-new-datadam-service-for-authentication
branch
October 8, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dbeaver/pro#10784
Summary
com.dbeaver.datadam.sso.apiOSGi/Maven module and export shared authorization, identity, token exchange and handoff DTOs.Related changes
Companion SSO server: https://github.com/dbeaver/datadam/pull/121.
Merge the API module before the server PR; build both issue branches together for validation.
Validation
Built together with the companion server through the DataDam aggregate:
git diff --checkpassed.Application integrations are a follow-up to the shared contracts and SSO service.