Repository navigation
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Protocol separation and OSGi visibility need correction, while shared-client transport guarantees still require human validation.
2 open issues
What changed in this PR
Adds an External DAM API module for Desktop messaging contracts and backend service integration.
Changes:
- Defines WebSocket registration, connection identity, and topic-based messaging contracts.
- Adds an account-scoped GraphQL client with separate service authentication.
- Includes validation tests, delivery documentation, and Maven/OSGi integration.
| File | Description |
|---|---|
| apis/pom.xml | Registers the new module. |
| apis/com.dbeaver.datadam.external.api/src/test/java/com/dbeaver/datadam/external/api/model/DDMessageTest.java | Tests payload isolation and validation. |
| apis/com.dbeaver.datadam.external.api/src/test/java/com/dbeaver/datadam/external/api/model/DDExternalDamConnectionTest.java | Tests connection metadata. |
| apis/com.dbeaver.datadam.external.api/src/test/java/com/dbeaver/datadam/external/api/DDExternalDamProtocolTest.java | Tests message encoding and decoding. |
| apis/com.dbeaver.datadam.external.api/src/test/java/com/dbeaver/datadam/external/api/DDExternalDamApiTest.java | Tests service-secret validation. |
| apis/com.dbeaver.datadam.external.api/src/test/java/com/dbeaver/datadam/external/api/client/DDExternalDamClientTest.java | Tests requests, authentication, and failures. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/transport/DDSubscription.java | Defines subscription cleanup. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/transport/DDMessageListener.java | Defines message callbacks. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/transport/DDMessageChannel.java | Defines messaging and subscriptions. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/transport/DDConnectionListener.java | Defines connection callbacks. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/model/DDReady.java | Models registration acknowledgment. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/model/DDMessage.java | Models messages with isolated payloads. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/model/DDHello.java | Models Desktop registration metadata. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/model/DDExternalDamConnection.java | Models backend connection results. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/model/DDConnectionInfo.java | Models connection identity. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/exception/DDExternalDamException.java | Defines client exceptions. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/DDExternalDamProtocol.java | Implements WebSocket message serialization. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/DDExternalDamApi.java | Defines endpoint and authentication constants. |
| apis/com.dbeaver.datadam.external.api/src/main/java/com/dbeaver/datadam/external/api/client/DDExternalDamClient.java | Implements account-scoped GraphQL operations. |
| apis/com.dbeaver.datadam.external.api/README.md | Documents authentication and delivery guarantees. |
| apis/com.dbeaver.datadam.external.api/pom.xml | Configures dependencies and tests. |
| apis/com.dbeaver.datadam.external.api/META-INF/MANIFEST.MF | Declares OSGi exports and dependencies. |
| apis/com.dbeaver.datadam.external.api/build.properties | Configures bundle packaging. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes dbeaver/pro#11108