perf: simplify comparison workflows - #1
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa6adc5f7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for row_index in nullish_rows_a { | ||
| push_unkeyed_right(&mut results, row_index, &context); | ||
| } | ||
|
|
||
| for row_index in nullish_rows_b { | ||
| push_unkeyed_left(&mut results, row_index, &context); | ||
| } |
There was a problem hiding this comment.
When flexible matching has a candidate set over 10,000 but a key-pair product below 1,000,000 (for example, the existing dense 101×101 case), the candidate-limit error is now detected only inside compare_key_groups_flexible, after these loops have built results for every nullish row. A CSV containing many empty keys can therefore allocate a large result vector before returning the validation error that previously occurred before result generation; prepare/check the flexible candidates before materializing unkeyed results. This affects both runtimes because the comparison engine belongs to their shared library.
AGENTS.md reference: AGENTS.md:L4-L4
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Resolved by the rebase onto current main: ComparisonPlan::build now surveys flexible candidates before execute emits any nullish/unkeyed rows, and run_comparison returns the recorded excess before calling plan.execute.
fa6adc5 to
e1b4fa4
Compare
e1b4fa4 to
65a062d
Compare
2 participants
Summary\n- eliminate duplicate CSV metadata work and centralize frontend workflow ownership\n- preserve flexible matching semantics with bounded incremental selection\n- make retained-session budget admission atomic and page result rendering\n\n## Verification\n- cargo fmt --check && cargo test && cargo clippy -- -D warnings\n- npm test && npm run build\n- (cd src-tauri && cargo fmt --check && cargo test)