feat(release): qualify the reviewed 8.4.0 picker offline - #79
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewer picker in merged PR #78 has provider-free UI and configuration coverage but cannot use the narrow same-minor patch exception. Add the explicitly authorized, feature-specific offline qualification path for 8.4.0.
The code-owned policy pins reviewer-picker-v1 to merged commit ff605d9. Every picker/adaptor source, package/build/type surface, and prior guide must match that reviewed commit's exact Git blob and regular-file mode. Other changed paths remain subject to the conservative existing tooling/documentation allowance. Another version, feature, reviewed commit, dependency change, changed frozen file, or unknown core path is rejected.
--featureis separate from--patchand--canary. Initialization and resume reverify exact candidate bytes, frozen scope and a fully qualified 8.3.0 baseline, with unchanged freshness limits. Conflicting modes/records fail. CI and publication run deterministic checks, replay and provider-free OpenCode smoke; no paid dispatch is started.The 8.4.0 record binds the prepared tarball and preserves the original 8.3.0 evidence under a current verifier seal. Added baseline objects repeat retained content-addressed evidence, not new provider runs. Notes explicitly disclose that no live model eval or canary ran for 8.4.0 and that prior 76/76 passes describe 8.3.0 only.
Validation: focused policy/publication/documentation tests passed; 13/13 gated replays reproduced; provider-free host smoke passed 21 tests, including real reviewer preference save/reset. The actual 8.4.0 initializer and committed feature record passed independent verification. Actionlint and typecheck passed. No tag or publication has occurred yet.
Final clean-worktree preflight passed: 1,192 tests passed, one opt-in smoke skipped, no failures. Typecheck, lint, metadata and build passed.