Skip to content

Add agbcc FE8J compiler#75

Merged
mkst merged 1 commit into
decompme:mainfrom
laqieer:add-agbcc-fe8j
Jul 20, 2026
Merged

Add agbcc FE8J compiler#75
mkst merged 1 commit into
decompme:mainfrom
laqieer:add-agbcc-fe8j

Conversation

@laqieer

@laqieer laqieer commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Adds the agbcc-fe8j compiler package for fireemblem8j issue #168.

The artifact is built from pret/agbcc da598c1 plus the default-off FE8J target flags on laqieer/agbcc@fe8j. The permanent release is fe8j-v1.

-mjp-promote preserves signed sub-word promotion and enables declaration-order function-argument promotion. With no FE8J flag, validated .text output matches stock agbcc; with -mjp-promote, the known AddGorgonEggTrap case produces the required FE8J argument-extension order. The packaged release also completed a clean full fireemblem8j build with fireemblem8.gba: OK.

A follow-up decomp.me application PR will register this package and add a focused compile test for -mjp-promote once this image is published.

Package the default-off-compatible agbcc build used by fireemblem8j so decomp.me can compile scratches with the project-local -mjp-promote target flag.

Co-authored-by: laqieer <laqieer@126.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 990a295e-cc42-4f64-8303-1599ab35abfb
@laqieer

laqieer commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@mkst This first contribution is waiting on Actions approval (action_required, no jobs created). When convenient, could you approve the workflow run for this PR? The release artifact and clean-ROM validation are summarized in the PR body.

@laqieer

laqieer commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

All Publish jobs are now green, including the gba/agbcc-fe8j image build. This is ready to merge when convenient; the dependent decomp.me PR is #2046.

@laqieer

laqieer commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@ethteck If you have merge access and a moment, this CI-green compiler package unblocks decompme/decomp.me#2046 and preset request #2047. The artifact provenance and clean FE8J ROM validation are in the PR body.

@mkst
mkst merged commit 3c1d81c into decompme:main Jul 20, 2026
3 checks passed
@mkst

mkst commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

quite pushy this copilot pr eh?

@laqieer
laqieer deleted the add-agbcc-fe8j branch July 23, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants