Skip to content

[Deepin-Kernel-SIG] [linux 6.6.y] [Upstream] remove hostap 802.11b driver - #2226

Merged
opsiff merged 4 commits into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2026-10-24-remove
Oct 24, 2026
Merged

opsiff merged 4 commits into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2026-10-24-remove

Conversation

@opsiff

@opsiff opsiff commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Summary by Sourcery

Remove the obsolete HostAP 802.11b driver and all related kernel configuration and build references.

Enhancements:

  • Remove the obsolete HostAP 802.11b wireless driver and its associated source files from the kernel tree.
  • Disable HostAP support across the supported Deepin architecture defconfig files and remove its maintainer and build configuration entries.

GustavoARSilva and others added 4 commits October 24, 2026 21:44
…e struct_size()

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

While there, use struct_size() helper, instead of the open-coded
version, to calculate the size for the allocation of the whole
flexible structure, including of course, the flexible-array member.

This code was found with the help of Coccinelle, and audited and
fixed manually.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/ZSRXXvWMMkm7qqRW@work
(cherry picked from commit 5cf47dc)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
The ioctl handler has no actual callers in the kernel and is useless.
All the functionality should be reachable through the regualar interfaces.

Acked-by: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231011140225.253106-9-arnd@kernel.org
(cherry picked from commit f35ccb6)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
HostAP is an ISA/PCMCIA style 802.11b driver supporting only
wireless extensions, and some custom ioctls (already removed).
Some devices include a legacy PCI bridge but no DMA.

The driver was marked obsolete in 2016 and is highly unlikely
to still have any users.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Conflicts:
	drivers/net/wireless/intersil/hostap/hostap_main.c
(cherry picked from commit d0172d5)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai

sourcery-ai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the obsolete HostAP 802.11b driver wholesale: all implementation and configuration files are deleted, Intersil build/Kconfig references and MAINTAINERS metadata are cleared, and HostAP-related options are removed from every supported Deepin desktop defconfig.

File-Level Changes

Change Details Files
Remove the obsolete HostAP 802.11b wireless driver implementation and its build integration.
  • Delete all HostAP driver source and header files, including PCI, PLX, and PC Card frontends, hardware management, AP, data-path, ioctl, and proc interfaces.
  • Remove the HostAP subdirectory from the Intersil wireless Makefile and Kconfig menu.
drivers/net/wireless/intersil/Makefile
drivers/net/wireless/intersil/Kconfig
drivers/net/wireless/intersil/hostap/Kconfig
drivers/net/wireless/intersil/hostap/Makefile
drivers/net/wireless/intersil/hostap/hostap.h
drivers/net/wireless/intersil/hostap/hostap_80211.h
drivers/net/wireless/intersil/hostap/hostap_80211_rx.c
drivers/net/wireless/intersil/hostap/hostap_80211_tx.c
drivers/net/wireless/intersil/hostap/hostap_ap.c
drivers/net/wireless/intersil/hostap/hostap_ap.h
drivers/net/wireless/intersil/hostap/hostap_common.h
drivers/net/wireless/intersil/hostap/hostap_config.h
drivers/net/wireless/intersil/hostap/hostap_cs.c
drivers/net/wireless/intersil/hostap/hostap_download.c
drivers/net/wireless/intersil/hostap/hostap_hw.c
drivers/net/wireless/intersil/hostap/hostap_info.c
drivers/net/wireless/intersil/hostap/hostap_ioctl.c
drivers/net/wireless/intersil/hostap/hostap_main.c
drivers/net/wireless/intersil/hostap/hostap_pci.c
drivers/net/wireless/intersil/hostap/hostap_plx.c
drivers/net/wireless/intersil/hostap/hostap_proc.c
drivers/net/wireless/intersil/hostap/hostap_wlan.h
Remove HostAP ownership metadata and disable the driver in all supported Deepin desktop kernel configurations.
  • Delete the HostAP entry from MAINTAINERS.
  • Remove CONFIG_HOSTAP and related HostAP-dependent configuration selections from ARM64, LoongArch, MIPS, RISC-V, and x86 desktop defconfig files.
MAINTAINERS
arch/arm64/configs/deepin_arm64_desktop_defconfig
arch/loongarch/configs/deepin_loongarch_desktop_defconfig
arch/mips/configs/deepin_loongson3_desktop_defconfig
arch/riscv/configs/deepin_riscv64_desktop_defconfig
arch/x86/configs/deepin_x86_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff
opsiff merged commit a1e3798 into deepin-community:linux-6.6.y Oct 24, 2026
13 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants