An empty ontology says what the documents still need, and no longer claims to cover them - #1083
Merged
Merged
Conversation
…laims to cover them The ontology page of a base with no classes said "Extraction adds them as documents arrive", which has not been true since extraction writes open statements (0044), and its Unmatched view said "the ontology covers your corpus" beside 22 kind words with no class: that sentence read 0003's ontology_misses, a table the open-graph extraction does not write to. The report the page already fetches now carries how many kind words have no class and how many phrase shapes bind to no property, the two things the agent reads. The view says those numbers and what to do, or says nothing is waiting; the empty canvas says what classes are for and has a button to that view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Found in an end-to-end run on dev, on a fresh base with six documents and no ontology.
ontology_misses(0003), which the open-graph extraction does not write to.So the first thing a new base told its owner about the ontology was wrong twice, and nothing pointed at the step that turns statements into typed facts.
What changes
GET /kbs/{id}/questions/reportgainsuncovered: { kind_words, phrases }: kind words with no class and phrase shapes bound to no property (noneorundecided). These are the two inputs the ontology agent reads (0061 decision 2).No change to what the agent does or when it runs.
How it was checked
an_empty_ontology_does_not_cover_the_corpus: nothing read yet, kind words with no class, bound againstnoneandundecided, and another base's rows not counted.cargo clippy -p utopia-server -p utopia-store --all-targets -- -D warnings,cargo fmt --all --check,pnpm typecheck,pnpm test(228),pnpm build.Before review
pnpm buildandpnpm testpasscrates/utopia-store/was tested withUTOPIA_DATABASE_URLseten.tsandzh.ts🤖 Generated with Claude Code