Read nested Notion blocks in page order - #1085
Open
Floating-Y wants to merge 1 commit into
Open
Floating-Y wants to merge 1 commit into
Floating-Y wants to merge 1 commit into
Conversation
Signed-off-by: Floating-Y <118035379+Floating-Y@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Notion's children endpoint returns one level at a time. The connector only read top-level blocks, omitting paragraphs inside toggles and columns. This fixes a traversal gap in the original connector, not a regression from the rate-limit fix in #269.
What changes
Pacedclient and oneMAX_BLOCKS_PER_PAGEbudget across the entire page, retaining request spacing, 429 retries, and Retry-After handling. Stop making requests when the budget is exhausted.child_pageandchild_databaseboundaries.How it was checked
Unchangedon the next identical sync.cargo fmt --all --checkandcargo clippy --locked --workspace --all-targets -- -D warningspassed.--test-threads=1passed with database and PDF checks required. The existing real-workspace smoke test was filtered out of that run; the dedicated live test above was run separately.Before review
git commit -s).cargo fmt --all --checkpassed.cargo clippy --locked --workspace --all-targets -- -D warningspassed.