Skip to content

Wait for all async all-gathers in coalesced ZeRO-3 parameter gather #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pengdurice merged 1 commit into from
Sep 21, 2026
Merged

Wait for all async all-gathers in coalesced ZeRO-3 parameter gather #8539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions deepspeed/runtime/zero/partition_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2088,8 +2088,10 @@ def _allgather_params_coalesced(self, param_list, hierarchy=0, quantize=False):
launch_quantize_handles.append(quant_handle)
launch_handles.append(h)

# Wait ensures the operation is enqueued, but not necessarily complete.
launch_handles[-1].wait()
# gloo handles are independent and the CPU synchronize() below is a
# no-op, so every handle must be waited on, not just the last one.
for handle in launch_handles:
handle.wait()
Comment on lines +2093 to +2094

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required Signed-off-by trailer

This is a non-merge commit, but its commit message contains no Signed-off-by trailer, violating the repository's mandatory commit requirement. Recreate the commit with git commit --signoff before merging.

AGENTS.md reference: AGENTS.md:L8-L8

Useful? React with 👍 / 👎.

if quantize:
for quant_handle in launch_quantize_handles:
quant_handle.wait()
Expand Down
Loading