feat: Added tests for ggplot2 - #1441
Open
NavandarM wants to merge 8 commits into
Open
Conversation
…box_inches='tight', foced to the same font family
… tests Plot-generating tests were leaking global rcParams (e.g. font.size set by plotEnrichment/correlation and never restored) across the pytest session, causing image-comparison tests like test_plotHeatmap and test_plotProfile to fail only when run as part of the full suite, never standalone. A single conftest.py fixture snapshots/restores rcParams around every test instead of duplicating ad-hoc cleanup per test file.
dd79381 replaced 6 baseline images with versions saved at the pre-centralization DPI (effectively dpi=100), while matplotlib_defaults.py sets savefig.dpi=200. Every affected test compared against a baseline exactly half the size in each dimension, failing on every run regardless of test order. Restores bamPEFragmentSize/plotCorrelation/plotCoverage/plotPCA baselines to the correctly-sized versions from a99d649 (dpi=200), and regenerates the plotFingerprint baseline fresh since its a99d649 version had a separate content mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Added test for ggplot2