Repository navigation
chore: remove vestigial apps/web/package-lock.json - #110
Open
martyy-code wants to merge 1 commit into
Open
martyy-code wants to merge 1 commit into
martyy-code wants to merge 1 commit into
Conversation
The repo is a pnpm monorepo (packageManager: pnpm@10.34.5). The npm lockfile in apps/web was a stale artifact from the first commit; it still pinned vulnerable postcss@8.4.31 and old next/fumadocs versions, and no CI step or build path reads it. Keeping it as a Dependabot signal is pure noise. - delete apps/web/package-lock.json - ignore package-lock.json and yarn.lock at the repo root - ignore package-lock.json in apps/web as defense-in-depth
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
codewizdave
pushed a commit
that referenced
this pull request
Oct 12, 2026
The previous wording said the direct `^8.5.15` range was the binding constraint. That was wrong: caret semver already permits 8.5.29, and no peer dependency was blocking the resolution. The real reason the lockfile still pinned vulnerable postcss versions was that it was a stale snapshot from the original commit; pnpm re-uses locked versions until the lockfile is regenerated. The regen alone would have cleared the alerts; this PR additionally raises the direct range to make the manifest explicit. Also drops the outdated follow-up note that pointed at PR #105, since PR #110 is the real cleanup for the npm lockfile.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The repo is a pnpm monorepo (
packageManager: pnpm@10.34.5in the rootpackage.json). The fileapps/web/package-lock.jsonwas a stale artifact from the first commit; no CI step, build, orpnpminstall reads it.The lockfile still pinned:
postcss@8.4.31(vulnerable — addressed in deps(apps/web): bump postcss ^8.5.15 -> ^8.5.23 (6/6, fills gap after #103) #107 by bumping the direct dep to 8.5.29)next@16.2.6andfumadocs-*@16.9.1(old — addressed in deps(apps/web): bump fumadocs-{core,mdx,ui} to clear transitive vulns (1/5) #101)Keeping it around is a permanent source of Dependabot noise that no longer matches the actual install graph. Dependabot scans all tracked lockfiles regardless of which tool the project uses.
Changes
apps/web/package-lock.jsonpackage-lock.jsonandyarn.lockto root.gitignorepackage-lock.jsontoapps/web/.gitignore(defense-in-depth)Verification
pnpm installdoes not consume npmpackage-lock.json🤖 Generated with Claude Code