Repository navigation
Rework sdk and sdk mapping urls format - #1081
Merged
Merged
Conversation
Summary - Extender code coverage reportSummary
Coveragecom/defold/extender - 43.6%
com/defold/extender/builders - 0%
com/defold/extender/cache - 32.8%
com/defold/extender/cache/info - 100%
com/defold/extender/jetty - 82.6%
com/defold/extender/log - 40%
com/defold/extender/metrics - 37.5%
com/defold/extender/process - 73.4%
com/defold/extender/progress - 90.6%
com/defold/extender/remote - 88.9%
com/defold/extender/services - 59.2%
com/defold/extender/services/cocoapods - 53%
com/defold/extender/services/data - 80.7%
com/defold/extender/services/spm - 40.7%
com/defold/extender/tracing - 21.2%
com/defold/extender/utils - 18.1%
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try (ClientHttpResponse response = doRequestWithRedirects(url, HttpMethod.GET, configuration.getMaxRedirectCount())) { | ||
| HttpStatusCode responseCode = response.getStatusCode(); | ||
| if (responseCode != HttpStatus.OK) { | ||
| LOGGER.info("The given sdk does not exist: {} {}", url, responseCode.toString()); |
| LOGGER.error(String.format("Error during loading sdk mappings for %s", hash), exc); | ||
| } | ||
| } catch(IOException|ParseException exc) { | ||
| LOGGER.error(String.format("Error during loading sdk mappings for %s", hash), exc); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-platform SDK and mappings URLs
extender.sdk.sdk-urlsandextender.sdk.mappings-urlsare now maps keyed by build platform instead of flat comma-separated lists.otheris the fallback for any platform without its own entry.Keys with _ must use bracket notation ("[x86_64-ps4]"), otherwise Spring strips the underscore and the entry is silently ignored.
Changes
DefoldSdkService.getSdk/getPlatformSdkMappingstake the platform and fetch from a single resolved URL.archive/%s/.... Thearchive/stable/%s/...fallback is removed.