Repository navigation
Use lists of URLS instaead of signle URL template - #1084
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f818169516
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+190
to
+192
| // mark sdk as found for download | ||
| sdkFound = true; | ||
| break; |
There was a problem hiding this comment.
When a URL returns 200 to HEAD but its subsequent download, checksum lookup, or verification fails, this new break commits to that URL and the retry loop only retries the same url; it never reaches the later configured URL patterns. With the new stable URL configured ahead of the hash-specific archive URL, a stale or partially unavailable stable artifact can therefore make SDK acquisition fail even though the fallback archive is usable. Continue through the remaining patterns after a failed GET or verification attempt.
Useful? React with 👍 / 👎.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try (ClientHttpResponse response = doRequestWithRedirects(url, HttpMethod.GET, configuration.getMaxRedirectCount())) { | ||
| HttpStatusCode responseCode = response.getStatusCode(); | ||
| if (responseCode != HttpStatus.OK) { | ||
| LOGGER.info("The given sdk does not exist: {} {}", url, responseCode.toString()); |
| break; | ||
| } | ||
| } catch(IOException|ParseException exc) { | ||
| LOGGER.error(String.format("Error during loading sdk mappings for %s", hash), exc); |
Summary - Extender code coverage reportSummary
Coveragecom/defold/extender - 43.6%
com/defold/extender/builders - 0%
com/defold/extender/cache - 32.8%
com/defold/extender/cache/info - 100%
com/defold/extender/jetty - 82.6%
com/defold/extender/log - 40%
com/defold/extender/metrics - 37.5%
com/defold/extender/process - 73.4%
com/defold/extender/progress - 90.6%
com/defold/extender/remote - 88.9%
com/defold/extender/services - 58.4%
com/defold/extender/services/cocoapods - 53%
com/defold/extender/services/data - 80.7%
com/defold/extender/services/spm - 40.7%
com/defold/extender/tracing - 21.2%
com/defold/extender/utils - 18.1%
|
ekharkunov
added a commit
that referenced
this pull request
Sep 28, 2026
* Use lists of URLS instaead of signle URL template * Fix how env parsed in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.