Repository navigation
Magento2: Extract queue consumers stop into its own task - #4273
Open
claudio-ferraro wants to merge 1 commit into
Open
claudio-ferraro wants to merge 1 commit into
claudio-ferraro wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
magento:cron:stopkills running cron jobs and queue consumers in one command. This PR moves the consumers part into its own task,magento:queue:consumers:stop.magento:cron:stopinvokes it, so its behaviour does not change.The new task is also useful on its own. A Magento queue consumer only stops after
max_messagesmessages. On a quiet queue that can take weeks, and until then the consumer runs the code of the previous release. It also keeps the lock on its name, so cron can't start the consumer from the new release. With the new task, a deploy can stop the consumers after the symlink, and cron starts them again from the new release: