Repository navigation
Parametric and frailty fits sort the count last, as canonical_rows (#777, canonical order) - #783
Merged
Merged
Conversation
, canonical order) canonical_order (the row order of every parametric regression, #728) sorted by time, censoring, count, truncation and covariates. canonical_rows (the semi-parametric fits', #772) puts the count last, so that counted data sort as their rows expanded one per unit do. The orders now agree: the count is canonical_order's last key, and grouped_data (the frailty fits', which follows canonical_order) puts it after the group. Only rows tied in time, censoring and truncation, with different counts, change places, so only the order of the likelihood's sums moves. On 84 fits of data with such ties (WeibullPH/AFT/PO, ExponentialPH, LogNormalAFT, WeibullFrailty, CoxFrailty, 12 seeds) every verdict is the same and the answers move at rounding: coefficients by up to 1e-13, a CoxFrailty theta by 2e-7 (its search tolerance), a theta at 0 from 5e-21 to 1e-16. The row-order tests (#744, #757, #772), the bootstrap tests, the doctests of the regression package and the executed cells of the two regression guides are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TRhKL2fJBiAAfNo9rihwts
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #777.
canonical_order (the row order of every parametric regression, #728)
sorted by time, censoring, count, truncation and covariates. canonical_rows
(the semi-parametric fits', #772) puts the count last, so that counted
data sort as their rows expanded one per unit do. The orders now agree:
the count is canonical_order's last key, and grouped_data (the frailty
fits', which follows canonical_order) puts it after the group.
Only rows tied in time, censoring and truncation, with different counts,
change places, so only the order of the likelihood's sums moves. On 84
fits of data with such ties (WeibullPH/AFT/PO, ExponentialPH,
LogNormalAFT, WeibullFrailty, CoxFrailty, 12 seeds) every verdict is the
same and the answers move at rounding: coefficients by up to 1e-13, a
CoxFrailty theta by 2e-7 (its search tolerance), a theta at 0 from 5e-21
to 1e-16. The row-order tests (#744, #757, #772), the bootstrap tests,
the doctests of the regression package and the executed cells of the two
regression guides are unchanged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TRhKL2fJBiAAfNo9rihwts
Generated by Claude Code