Repository navigation
Docs: the partial-effects check compares to rounding, not bit for bit - #988
Merged
Merged
Conversation
A hidden cell in Regression Modelling asserted that each partial-effects curve equals pump_model.sf(x, row) exactly. The plot evaluates every row in one batch and the check one row at a time, and numpy's vectorised exp/log on Linux can round the same value differently in another batch, so the docs build failed on one release run and passed on the one before. It compares to rtol 1e-12 now. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Km2eWBiPJ5JNkme3vRg4B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hidden cell in Regression Modelling with SurPyval asserted that each partial-effects curve equals
pump_model.sf(x, row)exactly. The plot evaluates every row in one batch, while the check evaluates one row at a time, and numpy's vectorised exp/log on Linux can round the same value differently in a different batch. As a result the docs job failed on one release run (#984) and passed on the run before. The check now compares atrtol=1e-12.🤖 Generated with Claude Code
https://claude.ai/code/session_019Km2eWBiPJ5JNkme3vRg4B