Repository navigation
ci(replace-wedding-standby): retry the database image pull on registry rate limits - #5855
Merged
Merged
Conversation
…y rate limits GHCR briefly answered toomanyrequests on the merge-group run for #5500, which failed the standby-replacement safety job although nothing was wrong. Retry the pull of the same pinned digest up to four times with backoff and fail only after the last attempt. Fixes #5514 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@codex review 🤖 Generated with Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
Author
Tried as a user, at
This PR's own run of the workflow does the real pull of the pinned digest on a GitHub runner. 🤖 Generated with Claude Code |
Contributor
Author
Status: held as a draft. The Codex review at the current head is clean. This change can't merge yet for two reasons outside it:
Next steps: once #5853 merges, update this branch from 🤖 Generated with Claude Code |
Contributor
✅
|
Contributor
Author
Blocker: none Cleared 2026-11-04: platform#5853 merged 2026-11-04T08:01Z; the organization Go workflow passes on main again and pull requests can pass their required checks (platform#5852 status 2026-11-04) Previous record (historical): |
…by-image-pull-5514 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@codex review 🤖 Generated with Claude Code |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
devantler
commented
Nov 4, 2026
devantler
left a comment
devantler
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer (interactive Claude Code session)
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: c2688c9
- CodeRabbit: rate-limited for this organisation since 2026-11-03 09:04Z (batch lane check); not requested.
- Codex: answered the 2026-11-04 request for this head with its code-review usage-limit message instead of a review.
- Cursor Bugbot: reached its usage limit at 2026-11-04 00:28Z; no review since.
Scope: the whole diff against main at this head, including the main merge. The step still pulls the same pinned digest, so the check examines the same image; the retry adds at most 60 seconds of pauses inside the job's 10-minute limit and fails with an error after the fourth attempt. There is no untrusted interpolation in the script. I re-ran the step's actual script with a fake docker: 1, 3 and 4 calls when the pull works after 0, 2 and 3 failures, and exit 1 with the error after 4.
Verdict: no P0/P1 findings
🤖 Generated with Claude Code
Contributor
Author
Tried as a user, at I took the step's actual script from the workflow at this head with
This PR's own run of 🛡️ Validate standby replacement safety passed at this head, so the real pull of the pinned digest worked on a GitHub runner. 🤖 Generated with Claude Code |
devantler
marked this pull request as ready for review
November 4, 2026 15:40
devantler
enabled auto-merge
November 4, 2026 19:38
devantler
disabled auto-merge
November 4, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The standby-replacement safety job pulls one pinned database image with a single
docker pull. On 28 October GHCR answeredtoomanyrequestsfor under a second during the merge-group run for #5500 (run 40693624595). That failed the job although nothing was wrong with the change, and the same thing can evict a merge-queue entry.What
The pull now retries up to four times with a growing pause (10, 20, 30 seconds) and fails with an error only after the last attempt. It still pulls the same pinned digest, so the check examines the same image. The pauses fit well inside the job's 10-minute limit.
Validation
actionlintpasses for the workflow.yq, underbash -ewith a fakedockerand no sleeps. It succeeds with 1 call when the pull works, 3 calls after two failures and 4 calls after three failures. After four failures it stops withdocker pull failed after 4 attemptsand exit code 1.Fixes #5514
🤖 Generated with Claude Code