Repository navigation
Keep a hand-made node's own position when it takes a form - #1508
Merged
Merged
Conversation
The stage kit gave every card and node with a data-form
`position: relative` through `:is(.wb-card, .wb-node)[data-form]`, which
weighs two classes. An agent's `.node { position: absolute }` weighs one,
so in a hand-made layout every node with a form fell back into normal
flow: the nodes stacked and the arrows drawn at fixed coordinates pointed
at nothing.
The form, change, outline and colour rules now match through `:where()`,
so they weigh one class, as the base card rule does. They still beat that
rule by coming after it, and an animation's own CSS comes after the kit
and wins. Tones and highlights keep their weight and still take over. The
scene's cards are unchanged: `.wb-scene > .wb-card` keeps them relative.
Agent-Session: cbacb871-2558-4fe4-9272-77524bb21683
Agent-Session: ffed49d6-ca86-4940-b93c-e8eb7e0de440
Agent-Session: d7e3a290-82a4-4f66-9b3c-7a52a51add18
Agent-Session: dd060ef0-ff50-449e-a1a7-c2151a3d0d60
thesiti92
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1498, a hand-made animation whose
wb-nodeelements are placed absolutely and take adata-formdraws every node in normal flow: the nodes stack and overlap, and the SVG arrows drawn at fixed coordinates point at empty space.animation.mdinvitesdata-formon awb-nodein a hand-made layout, so this is the documented use.The cause is the kit's
:is(.wb-card, .wb-node)[data-form] { position: relative; }, which weighs two classes (0,2,0) and beats an agent's.node { position: absolute }(0,1,0).The fix
The form, change, outline and colour rules in
animation-stage-kit.tsnow match through:where(.wb-card, .wb-node)[…], so they weigh one class:.wb-card, .wb-noderule and win by coming after it, so a form's padding, radius and::before/::afterstill draw when the agent sets nothing.The scene's own cards are unchanged.
.wb-scene > .wb-cardkeeps them relative, and the legend glyphs have their own two-class rule. The resting frames ofrequest-across-layersandcache-fill-evict(window, bars, cylinder, drum, change stripe, legend) are byte-identical before and after.Test
blocks.browser.test.tsxadds a 720×420.architecturelayout with twonode wb-nodecards (data-form="bars") at#a{left:12px;top:10px}and#b{left:262px;top:162px}. The stage reports through the code slot's width whether both kept their position. The test fails on main and passes with the fix.