Repository navigation
Conversation
On Windows and Linux the window controls sit over the top-right corner of whichever part reaches it, but the canvas never learned their width: a guided tour's close button, fullscreen or in the right column, sat under them, and so did the close buttons of side peeks and Ask in that column. The workbench now writes --review-chrome-right-width on the part at the window's top-right corner, an editor group or the Ask column, only when it changes. Panel headers read it into their right padding: the right column's header and a fullscreen tour's panel set the inset, so nothing moves on macOS or where no controls cover the canvas. Fixes devdotfast#1490 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows and Linux the window controls sit over the top-right corner of whichever part reaches it, but the canvas never learned their width: a guided tour's close button, fullscreen or in the right column, sat under them, and so did the close buttons of side peeks and Ask in that column.
The workbench now writes --review-chrome-right-width on the part at the window's top-right corner, an editor group or the Ask column, only when it changes. Panel headers read it into their right padding: the right column's header and a fullscreen tour's panel set the inset, so nothing moves on macOS or where no controls cover the canvas.
Fixes #1490