Skip to content

Keep canvas headers clear of the Windows window controls - #1513

Merged
thesiti92 merged 2 commits into
mainfrom
fix/windows-controls-inset
Nov 4, 2026
Merged

thesiti92 merged 2 commits into
mainfrom
fix/windows-controls-inset

Conversation

@thesiti92

Copy link
Copy Markdown
Contributor

On Windows and Linux the window controls sit over the right end of the top row, and nothing in the canvas made room for them. The tour's close button, in the right-hand column and in a fullscreen tour, sat under them, so it could only be closed with Escape. The board's page bar lost its Discord, Report a bug, Diff settings and More buttons the same way.

Fixes #1490.

Changes

  • Desktop publishes --review-window-controls-end on the editor and Ask parts: how far the titlebar's right cluster overlaps each part. It reuses the titlebar's zoom-aware width, so it holds at any zoom. It is 0 on macOS, and 0 on the editor part while the right column sits between it and the controls.
  • The page bar, the right-column header and fullscreen headers pad by it. Only the column that reaches the window's top-right corner does; a fullscreen tour's left column, and a flow tour's panel stacked under its stage, keep their padding.
  • Fullscreen header rows (tours, expanded diagrams, the software map) are now page-bar height (40px), so their rule meets the bottom of the window controls. On macOS they grow from 35/36px to 40px too. Inline diagram headers are unchanged.

Testing

  • Windows 11 (Parallels) with this branch's canvas and host change applied to 0.5.1: the page bar, the side tour and the fullscreen tour clear the controls at 100% and 120% zoom and in a narrow window; both close buttons work with real clicks.
  • Not run: Linux, and a narrow fullscreen flow tour.
  • pnpm lint, canvas and fork typechecks, fork tests, and the side panel browser tests.

On Windows and Linux the window controls sit over the right end of the top row. The tour's close button and the page bar's last buttons sat under them. Desktop now publishes how far the controls overlap each part, the top-right headers pad by it, and fullscreen header rows match the controls' height.

Fixes #1490.

Agent-Session: 9384a605-d9c3-4fb4-90ee-785315d819c8
Agent-Session: e35ee3f1-35bb-443a-a7fa-2d0fcb48c31e
Agent-Session: b8a1d0cf-9b38-4aa4-b9f2-62aeab83bfb0
Agent-Session: 9384a605-d9c3-4fb4-90ee-785315d819c8
Agent-Session: e35ee3f1-35bb-443a-a7fa-2d0fcb48c31e
Agent-Session: b8a1d0cf-9b38-4aa4-b9f2-62aeab83bfb0
@thesiti92
thesiti92 enabled auto-merge (squash) November 4, 2026 17:46
@thesiti92
thesiti92 merged commit 07deb9e into main Nov 4, 2026
3 checks passed
@thesiti92
thesiti92 deleted the fix/windows-controls-inset branch November 4, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On Windows, a tour's close button sits under the window controls

2 participants