clean up diffr machinery in remote stack by thesiti92 · Pull Request #945 · devdotfast/whiteboard

thesiti92 · 2026-10-05T21:59:19Z

Stacked on #949. Installs diffr on remote hosts from npm.

#965 already moved Desktop and the server to the bundled @dev.fast/diffr platform package. The stack's fetched-diffr path (ensureDiffr, remote diffr ensure, the diffr field in remote attach) is gone from the lower layers, so this PR is only the remote install.

Remote installs keep --omit=optional, which leaves out ~650 MB of agent binaries. The install script reads diffr's version from the package tarball and also installs @dev.fast/diffr-<target>@<version>. A host without registry access gets it through Desktop's relay.
The installer containers test checks the diffr binary on both the normal and the sealed host; the remote-install journey checks that diffr came through the relay.

Test plan

Root typecheck (including the Code OSS fork), pnpm lint, pnpm format:check.
Code OSS electron-main/remote/*.test.ts (188 pass, containers test excluded).
WB_TEST_CONTAINERS=1 installer containers test.
remote-install journey.

…eway

thesiti92 · 2026-10-08T12:59:32Z

Folded into #940: the diffr install step needs #940's --omit=optional, so it lives there now. #973 is stacked on #949.

Stacked PR 7 of 9 for remote reviews (base: `remote/6-installer-connect`; #934, the rename, is merged). Review in order; each PR builds and passes its suites on its own. ## Manual test plan **Purpose.** Ask works on a review whose checkout is on a host: the headless server serves Ask, the agent runs on the host with its own sign-ins, and threads live on the host. File names in answers show as text because Source windows do not exist yet. **Setup.** Worktree at `origin/remote/7-remote-ask`. `R up a --fake-agent; R install a` (a fake OpenCode that answers `You asked: <question>`). Create the remote review on a. Launch; add `wb-test-a`. **Steps.** 1. Open Remote-order, select "One now returns", press ⌘L → Ask opens; its header names OpenCode with no agent menu (main's #914: one installed agent gets no dropdown). 2. `S wb-test-a 'mv ~/.opencode ~/.opencode.off'`, refocus the window → Claude Code, Codex and OpenCode each read `Not installed on wb-test-a`. Move it back → the composer returns. 3. Ask `what does f.ts do` → `You asked: what does f.ts do` streams in. 4. `f.ts` in the answer is plain text with the tooltip `Source windows are not available for a review on another machine.`; clicking it does nothing. 5. Kill Desktop's master (PR 3 step 7) → host back `online` → **Saved conversations** lists the thread. 6. Quit and relaunch Desktop → the thread is still listed. 7. Quit; launch again with a fresh `DEV_REVIEW_HOME` (redo the settings file), add the host → the same thread is listed (threads are on the host). 8. Ask `and then`, then `R pause a` → the panel shows an alert containing `lost its connection` within 15 s; the host reads `offline` within 15 s. `R resume a`. 9. Remove the host → the review leaves Home. **Negative checks.** - DevTools Network: every Ask request goes to `$URL`; none carries the remote token; no `navigator` or `files` request. - Idle threads closing 10 min after their last watcher leaves (main's Ask sweep, #948): not practical by hand; covered by `src/server/headless-host.test.ts`. Journey `remote-ask`. **Cleanup.** Common cleanup; also `rm -rf` the second home. **Folded in from #945.** Remote installs keep `--omit=optional` (drops ~650 MB of agent binaries), so the install script reads diffr's version from the tarball and installs `@dev.fast/diffr-<target>@<version>` explicitly. The installer containers test checks the diffr binary; `remote-install` checks it came through the relay. **Rebased onto main's Ask changes (#947, #948).** One `POST ask/watch` stream replaces the per-thread watch route, and the gateway forwards it plus `GET ask/:thread` (saved conversations). The stack's own headless idle close is gone; main's sweep covers it. <details><summary>Common setup for all plans</summary> ## Common setup (read once) - Test each PR in a worktree at its head branch: `git -C <core> worktree add --detach ../review-prN origin/<head>`, then `pnpm install` there. Run everything below from that worktree root. - Helpers (bash or zsh): ```sh R() { node apps/review-desktop/scripts/e2e/remote/remote.mjs "$@"; } export WB_TEST_RUN=manual-$$ # before the first `R up` S() { ssh -F /tmp/wbt.$WB_TEST_RUN/ssh_config "$@"; } # host aliases are wb-test-<name> H=/tmp/wb-home-$WB_TEST_RUN # isolated Desktop home mkdir -p $H/review-desktop/state/user-data/User echo '{"review.experimental.remoteHosts.enabled": true}' > $H/review-desktop/state/user-data/User/settings.json awk '/createRemoteReview = String.raw`/{f=1;next} /^`;/{f=0} f' apps/review-desktop/scripts/e2e/journeys/remote-host.mjs > /tmp/wb-review.sh sed -e 's/open\\":false/open\\":true/' -e 's/wbrepo/wbrepo2/g' /tmp/wb-review.sh > /tmp/wb-push.sh edit() { printf '{"sessionId":"%s","edit":{"type":"insert","content":{"type":"markdown","markdown":"%s"}}}' "$2" "$3" | S "$1" 'whiteboard api session_edit -'; } ``` - Launch (dev build only; a packaged build ignores both env vars): `DEV_REVIEW_HOME=$H DEV_FAST_REVIEW_SSH_CONFIG=/tmp/wbt.$WB_TEST_RUN/ssh_config pnpm dev` (prefix `DEV_FAST_REVIEW_DESKTOP_BACKGROUND=1` to keep it from taking focus). - Desktop API: `D=$(ls $H/review-desktop/instances/dev-*.json); URL=$(node -p "require('$D').url"); TOK=$(node -p "require('$D').token"); api() { curl -s -H "x-review-token: $TOK" "$URL$1"; }` - A remote review: `ID=$(S wb-test-a 'bash -s -- Remote-order' < /tmp/wb-review.sh | head -1)` (repo `~/wbrepo`, review "Remote-order" with a prose line and a code peek of f.ts). `/tmp/wb-push.sh` is the same with `open: true` in `~/wbrepo2`. - Settings: ⌘, → region **Remote hosts** → type the alias in **SSH alias** → **Add**. - Fork unit tests: `(cd apps/review-desktop && TSX_TSCONFIG_PATH=tsconfig.test.json node --import tsx --test --test-force-exit <files>)`. Package tests: `pnpm --filter @dev.fast/whiteboard test <files>`. - Journeys: stage a runtime per `apps/review-desktop/scripts/e2e/TESTING.md` ("Staging the runtime"), then `node apps/review-desktop/scripts/e2e/run.mjs --runtime "$REVIEW_E2E_RUNTIME" --journey <name>`. - The harness has `pause`/`resume` (there is no `unpause`). - Cleanup, every plan: quit Desktop first (its `ssh` masters count as leftovers), then `R down --all; R verify-clean; rm -rf $H /tmp/wb-*.sh`. Without an `aws sso login` session `verify-clean` also prints `AWS could not be checked` and exits 1; no other line may appear. </details>

thesiti92 force-pushed the remote/10-diffr-npm-packages branch 2 times, most recently from 1aeb32b to b9736dd Compare October 5, 2026 22:26

thesiti92 force-pushed the remote/9-source-windows branch 5 times, most recently from 4c2c1ae to 1214041 Compare October 6, 2026 03:46

thesiti92 force-pushed the remote/10-diffr-npm-packages branch from b9736dd to 0a501e8 Compare October 6, 2026 03:46

thesiti92 changed the base branch from remote/9-source-windows to remote/10-gateway-transport October 6, 2026 13:09

thesiti92 added this pull request to stack #943 October 6, 2026 13:09

thesiti92 force-pushed the remote/10-diffr-npm-packages branch from 0a501e8 to ca62a03 Compare October 6, 2026 13:19

thesiti92 mentioned this pull request Oct 6, 2026

Integrate diffr 0.1.13 and migrate saved config at startup #956

Closed

thesiti92 force-pushed the remote/10-diffr-npm-packages branch from ca62a03 to 8a0ecc7 Compare October 6, 2026 15:57

thesiti92 force-pushed the remote/10-gateway-transport branch 2 times, most recently from 09ab700 to cff15cc Compare October 6, 2026 16:06

thesiti92 force-pushed the remote/10-diffr-npm-packages branch 2 times, most recently from 2ab72e1 to bb5d597 Compare October 6, 2026 16:16

thesiti92 force-pushed the remote/10-gateway-transport branch 2 times, most recently from 6bd9583 to f036686 Compare October 6, 2026 17:10

thesiti92 force-pushed the remote/10-diffr-npm-packages branch from bb5d597 to 9814fe6 Compare October 6, 2026 17:10

thesiti92 mentioned this pull request Oct 7, 2026

Show a remote host's state and next step on its reviews #973

Merged

5 tasks

thesiti92 added 9 commits October 7, 2026 09:28

Run the review server headless and route remote reviews through a gat…

03d1ba9

…eway

Connect to remote hosts over SSH

47b28fd

Ship a trimmed VS Code server to remote hosts

2657953

Run one extension host per remote host

b0687b4

Install Whiteboard on a host from Settings and connect its agents

8950fdc

Ask on remote reviews

654d250

Resolve and configure Source windows for remote hosts

6ecbc16

Open Source windows for remote reviews

b7e28f3

Move the remote gateway onto undici and one Hono route table

c9b8536

Install diffr from its npm platform package

aeb3f67

thesiti92 force-pushed the remote/10-gateway-transport branch from f036686 to c9b8536 Compare October 7, 2026 13:31

thesiti92 force-pushed the remote/10-diffr-npm-packages branch from 9814fe6 to aeb3f67 Compare October 7, 2026 13:31

thesiti92 changed the title ~~Install diffr from its npm platform package~~ clean up diffr machinery in remote stack Oct 7, 2026

thesiti92 force-pushed the remote/10-gateway-transport branch from c9b8536 to 76c4cfc Compare October 8, 2026 12:59

thesiti92 mentioned this pull request Oct 8, 2026

Ask on remote reviews #940

Merged

thesiti92 closed this Oct 8, 2026

thesiti92 removed this pull request from stack #943 October 13, 2026 15:38

Navigation Menu

Repository navigation

clean up diffr machinery in remote stack - #945

clean up diffr machinery in remote stack#945
thesiti92 wants to merge 10 commits into
remote/10-gateway-transportfrom
remote/10-diffr-npm-packages

thesiti92 commented Oct 5, 2026 •

edited

Loading

Uh oh!

thesiti92 commented Oct 8, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

thesiti92 commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

Uh oh!

thesiti92 commented Oct 8, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

thesiti92 commented Oct 5, 2026 •

edited

Loading