refactor: Add Device type=discovered/activated column to the device dashboard - #3535
Open
ShradhaGupta31 wants to merge 3 commits into
Open
refactor: Add Device type=discovered/activated column to the device dashboard#3535ShradhaGupta31 wants to merge 3 commits into
ShradhaGupta31 wants to merge 3 commits into
Conversation
ShradhaGupta31
changed the title
ShradhaGupta31
force-pushed
the
device-type-column
branch
from
August 31, 2026 14:08
f63a7b5 to
045cf2c
Compare
ShradhaGupta31
changed the title
ShradhaGupta31
changed the base branch from
main
to
device-discovery-UI-changes
September 1, 2026 04:49
ShradhaGupta31
force-pushed
the
device-type-column
branch
from
September 1, 2026 04:57
36a5a5a to
be30f08
Compare
ShradhaGupta31
force-pushed
the
device-type-column
branch
from
September 3, 2026 05:29
be30f08 to
41a52d7
Compare
- Add All/Activated/Discovered tab group to devices list - Add Product Type column derived from fwSku bitmask (ISM/vPro) - Add discovered field to DeviceInfo model - Show paginator on all tabs using server total count - Add i18n keys for tab labels and Product Type header in all 12 locales - Add unit tests for getProductType and tab filter logic - Fix cdk-overlay-backdrop leak in device.spec.ts cypress test Resolves: #3417
- updated logic to include server side counts Signed-off-by: ShradhaGupta31 <shradha.gupta@intel.com>
Signed-off-by: ShradhaGupta31 <shradha.gupta@intel.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new column currently presents a sortable UI that won’t actually sort and the device-type classification should align with the backend’s discovered/activated flag while also addressing the activated-chip contrast.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Devices dashboard table to display a new per-device “Type” column that labels devices as Discovered vs Activated, including localized column headers, UI styling, and unit tests for the new classification helper.
Changes:
- Add
deviceTypecolumn to the devices table (with chip-style rendering and activated-state styling). - Introduce
getDeviceType()helper and add unit tests for its behavior. - Add the
devices.table.typetranslation entry across all supported locales.
File summaries
| File | Description |
|---|---|
| src/assets/i18n/ar.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/de.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/en.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/es.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/fi.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/fr.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/he.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/it.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/ja.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/nl.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/ru.json | Adds localized “Type” table header key (devices.table.type). |
| src/assets/i18n/sv.json | Adds localized “Type” table header key (devices.table.type). |
| src/app/devices/devices.component.ts | Adds deviceType to displayed columns and implements getDeviceType(). |
| src/app/devices/devices.component.html | Renders the new Device Type column and applies chip styling. |
| src/app/devices/devices.component.scss | Adds chip styling for product/device type, including activated styling. |
| src/app/devices/devices.component.spec.ts | Adds unit tests covering getDeviceType() behavior. |
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+140
to
+142
| <mat-header-cell *matHeaderCellDef mat-sort-header>{{ | ||
| 'devices.table.type.value' | translate | ||
| }}</mat-header-cell> |
Comment on lines
+24
to
+27
| .device-type-chip.activated { | ||
| background: #03a9f4; | ||
| color: #fff; | ||
| } |
Comment on lines
+440
to
+443
| getDeviceType(device: Device): DeviceFilterStatus { | ||
| const currentMode = device.deviceInfo?.currentMode?.trim().toLowerCase() | ||
| return currentMode && currentMode !== 'not activated' ? 'activated' : 'discovered' | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add type=discovered/activated column to the device dashboard
Addresses: #3432