fix(cloud): refuse a device matrix on an API that cannot honour it#80
Merged
Merged
Conversation
An API predating #1105 does not merely lack the feature — it accepts the submission and SILENTLY STRIPS the unknown deviceMatrix field, because the API's global ValidationPipe runs whitelist:true / forbidNonWhitelisted:false. Every flow then runs on a single default device and the run exits 0. The user asked for N devices, tested one, and is told nothing: the exact silent under-testing the device matrix exists to prevent, and the worst outcome the feature can produce. The estimate endpoint is only called when a matrix was requested, so a null estimate (gateway maps 404/405 -> null) is a definitive 'API too old' signal. Fail loudly there instead of proceeding. This also removes the ordering footgun for the prod rollout structurally rather than by remembering it: if the CLI ever reaches an API without the matrix (stale deploy, rollback, lagging self-host), it now refuses instead of quietly under-testing. Verified against a local Prism mock served from PRODUCTION's swagger (no estimateMatrix): matrix run refuses with exit 1; a legacy single-device run on the same API still succeeds with exit 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An API predating #1105 does not merely lack the feature — it accepts the submission and SILENTLY STRIPS the unknown deviceMatrix field, because the API's global ValidationPipe runs whitelist:true / forbidNonWhitelisted:false. Every flow then runs on a single default device and the run exits 0. The user asked for N devices, tested one, and is told nothing: the exact silent under-testing the device matrix exists to prevent, and the worst outcome the feature can produce.
The estimate endpoint is only called when a matrix was requested, so a null estimate (gateway maps 404/405 -> null) is a definitive 'API too old' signal. Fail loudly there instead of proceeding.
This also removes the ordering footgun for the prod rollout structurally rather than by remembering it: if the CLI ever reaches an API without the matrix (stale deploy, rollback, lagging self-host), it now refuses instead of quietly under-testing.
Verified against a local Prism mock served from PRODUCTION's swagger (no estimateMatrix): matrix run refuses with exit 1; a legacy single-device run on the same API still succeeds with exit 0.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.