fix: honor the buffer window in every send path - #245
Open
SendableMetatype wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTCDataChannel.send behaves differently depending on the buffer it is handed: a heap buffer with an accessible backing array sends the entire backing array regardless of position and limit, a read only heap buffer honors the window, and a direct buffer sends the full capacity. Any caller that slices, flips, or reuses a buffer silently transmits the wrong bytes.
All paths now send exactly the bytes between position and limit, read through a duplicate so the caller's buffer state is untouched. Java only, no native changes.