feat: bridge OnIceSelectedCandidatePairChanged to Java observers - #247
Open
SendableMetatype wants to merge 1 commit into
Open
feat: bridge OnIceSelectedCandidatePairChanged to Java observers#247SendableMetatype wants to merge 1 commit into
SendableMetatype wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine reports every selected candidate pair change through OnIceSelectedCandidatePairChanged, but the Java observer interface has no corresponding callback, so an application cannot learn the remote transport address at nomination time or follow pair migrations afterwards.
Adds PeerConnectionObserver.onSelectedCandidatePairChanged(String remoteAddress, int remotePort, String candidateType), fired on every nomination and re nomination. Implemented as a default method, so existing observers are unaffected.