Repository navigation
Conversation
CI failed: Golangci-lint failed because a line length exceeds the 120-character limit in a new Helm chart test file.Overview1 failure found in total logs, caused by a linter rule violation in a newly added file. FailuresGolangci-Lint Line Length Violation (confidence: high)
Summary
Code Review ✅ Approved🔴 High risk · The new scheduler scraper sends zxporter’s ServiceAccount token with TLS verification disabled, so interception could expose cluster credentials. Release v0.1.21 advance to main — the tag is already created and in use by ArgoCD and other consumers. No issues found.
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
| if err == nil && pool.AppendCertsFromPEM(caData) { | ||
| tlsConfig.RootCAs = pool | ||
| } else { | ||
| tlsConfig.InsecureSkipVerify = true //nolint:gosec // see schedulerMetricsCAFileEnv doc comment. |
| tlsConfig.InsecureSkipVerify = true //nolint:gosec // see schedulerMetricsCAFileEnv doc comment. | ||
| } | ||
| } else { | ||
| tlsConfig.InsecureSkipVerify = true //nolint:gosec // see schedulerMetricsCAFileEnv doc comment. |
Release v0.1.21 of zxporter, published from the internal services monorepo.
The
v0.1.21tag has already been created and points at this branch's tip — ArgoCD and other tag consumers can use it immediately. This PR is only to advance public main to the released commit for browser convenience.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.