build(deps-dev): bump esbuild from 0.25.12 to 0.28.1 - #76
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.25.12 to 0.28.1. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2025.md) - [Commits](evanw/esbuild@v0.25.12...v0.28.1) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.28.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
The four JavaScript actions run from a committed dist/index.js, so every runtime dependency is bundled into it. That makes the bundles large generated artifacts sitting in the middle of every review: bumping undici rewrites about 800 lines across all four, and bumping esbuild, which is the bundler itself, rewrites about 800 more. Marks them as generated in .gitattributes so they collapse in pull request diffs. Reviewers see the source changes, and check_dist:required continues to guarantee that the collapsed output is exactly what that source compiles to. They are deliberately not marked -diff as well, since check-dist compares the output of git diff dist/ and needs it to stay textual. Adds a Rebuild dist workflow. Automated dependency updates change package.json and pnpm-lock.yaml but cannot rebuild the bundles, so check_dist:required fails on those pull requests until somebody rebuilds locally. #76 has been red for seven weeks for exactly this reason. The workflow is dispatched with a branch name, rebuilds and pushes only if something changed. It is deliberately manually dispatched rather than triggered on pull_request. Rebuilding an untrusted branch needs a privileged token, and pull_request_target would build that branch's code with it. Since a dependency update can bump the bundler itself, that is not a boundary worth crossing automatically. Dispatching keeps a human deciding which branch to trust. Also adds extract-version to the check_dist matrix. It is a node24 action with an 856K bundle that was not covered, so a stale bundle there went unverified. Its committed bundle is currently in sync. Documents all of this in CONTRIBUTING.md, including the part that is easy to miss: a dependency fix without rebuilt bundles does not change what runs. Adds a matching convention to the README, since this repo documents conventions for other repositories too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The four JavaScript actions run from a committed dist/index.js, so every runtime dependency is bundled into it. That makes the bundles large generated artifacts sitting in the middle of every review: bumping undici rewrote about 800 lines across all four in #79, and bumping esbuild, which is the bundler itself, would rewrite about 800 more in #76. Marks them as generated in .gitattributes so they collapse in pull request diffs. Reviewers see the source changes, and check_dist:required continues to guarantee that the collapsed output is exactly what that source compiles to. They are deliberately not marked -diff as well, since check-dist compares the output of git diff dist/ and needs it to stay textual. Adds extract-version to the check_dist matrix. It is a node24 action with an 856K bundle that was not covered, so a stale bundle there went unverified, and it is the action release workflows use to read the version being published. Its committed bundle is currently in sync, so this adds coverage without requiring a rebuild. Documents both in CONTRIBUTING.md, including the part that is easy to miss: a dependency fix without rebuilt bundles does not change what runs, because the lockfile is not consulted when GitHub executes an action. Adds a matching convention to the README, since this repo documents conventions for other repositories too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The four JavaScript actions run from a committed dist/index.js, so every runtime dependency is bundled into it. That makes the bundles large generated artifacts sitting in the middle of every review: bumping undici rewrote about 800 lines across all four in #79, and bumping esbuild, which is the bundler itself, would rewrite about 800 more in #76. Marks them as generated in .gitattributes so they collapse in pull request diffs. Reviewers see the source changes, and check_dist:required continues to guarantee that the collapsed output is exactly what that source compiles to. They are deliberately not marked -diff as well, since check-dist compares the output of git diff dist/ and needs it to stay textual. Adds extract-version to the check_dist matrix. It is a node24 action with an 856K bundle that was not covered, so a stale bundle there went unverified, and it is the action release workflows use to read the version being published. Its committed bundle is currently in sync, so this adds coverage without requiring a rebuild. Documents both in CONTRIBUTING.md, including the part that is easy to miss: a dependency fix without rebuilt bundles does not change what runs, because the lockfile is not consulted when GitHub executes an action. Adds a matching convention to the README, since this repo documents conventions for other repositories too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Closing rather than landing. The two advisories in 0.28.1 do not apply to how this repository uses esbuild — every build.mjs calls esbuild.build() with bundle/platform/target/conditions, with no dev server, no minifier and no Deno API — and pnpm audit reports no vulnerabilities at any severity on main, so audit:required is not blocked by this. That leaves three minors of codegen improvements in a build-time devDependency, against a branch ten commits behind with automatic rebases disabled, whose check_dist failures need the bundles rebuilt by hand. Not worth carrying. esbuild can be bumped deliberately later as a one-line change plus a rebuild. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps esbuild from 0.25.12 to 0.28.1.
Release notes
Sourced from esbuild's releases.
... (truncated)
Changelog
Sourced from esbuild's changelog.
... (truncated)
Commits
bb9db84publish 0.28.1 to npm9ff053esecurity: add integrity checks to the Deno API0a9bf21enforce non-negative size in gzip parsere2a1a71security: forbid\\in local dev server requests83a2cbffix #4482: don't inlineusingdeclarations308ad74fix #4471: renaming of nestedvardeclarationsf013f5ffix some typosaafd6e4chore: fix some minor issues in comments (#4462)15300c3follow up: cjs evaluation fixes1bda0c3fix #4461, fix #4467: esm evaluation fixesMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for esbuild since your current version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.