code cleanup - #56
Merged
Merged
Conversation
SingletonRepository<T> had exactly one instantiation (Balance) anywhere in the codebase. A generic base existed for a single use site.
Replace hand-rolled byte[8192] read/write loop in downloadAndDecompressExport with stdlib InputStream.transferTo (Java 9+, build targets 11). Tightened the existing end-to-end decompression test to assert exact output instead of partial contains() checks, pinning current behavior before the swap.
|
Fivell
changed the title
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup in the SDK by introducing a dedicated BalanceRepository, simplifying export decompression using the Java standard library, and tightening an export decompression test assertion.
Changes:
- Replace the generic singleton-style repository with a dedicated
BalanceRepositoryand updateDidwwClient.balance()to use it. - Simplify gzip decompression by replacing a manual read/write loop with
InputStream.transferTo(...). - Update
ExportTestto assert full CSV equality after decompression.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/didww/sdk/repository/BalanceRepository.java | Introduces a dedicated repository for the balance singleton endpoint. |
| src/main/java/com/didww/sdk/DidwwClient.java | Switches balance() to return BalanceRepository and simplifies decompression implementation. |
| src/test/java/com/didww/sdk/resource/ExportTest.java | Strengthens decompression test assertion to match full expected CSV content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
131
to
134
| // Singleton repository | ||
| public SingletonRepository<Balance> balance() { | ||
| return new SingletonRepository<>(httpClient, converter, baseUrl, "balance", Balance.class, objectMapper); | ||
| public BalanceRepository balance() { | ||
| return new BalanceRepository(httpClient, converter, baseUrl, "balance", objectMapper); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the generic SingletonRepository with a dedicated BalanceRepository, swapped a manual buffer-copy loop for a standard library call, and removed an empty leftover test folder. No behavior changes, all tests pass.