code cleanup - #43
Merged
Merged
Conversation
SingletonRepository had exactly one subclass (BalanceRepository) anywhere in the codebase. Ported over from a shared base class that never gained a second consumer.
|
Fivell
changed the title
There was a problem hiding this comment.
Pull request overview
This PR refactors the balance resource access layer by removing the generic SingletonRepository base class and replacing its only internal usage with a dedicated BalanceRepository, aiming to simplify the repository hierarchy.
Changes:
- Removed
SingletonRepositoryfromdidww.resources.base. - Implemented
BalanceRepositorydirectly indidww.resources.balancewith an inlinefind()implementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/didww/resources/base.py | Removes the shared singleton repository base class. |
| src/didww/resources/balance.py | Adds a dedicated repository implementation for the balance endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
377
to
378
|
|
||
| class SingletonRepository: | ||
| _resource_class = None | ||
| _path = None | ||
|
|
||
| def __init__(self, client): | ||
| self.client = client | ||
|
|
||
| def find(self, params=None): | ||
| query = params.to_dict() if params else None | ||
| body = self.client.get(self._path, params=query) | ||
| response = JsonApiResponse.from_data(body) | ||
| resource = self._resource_class.from_response_content(response) | ||
| return ApiResponse(data=resource, meta=body.get("meta", {})) | ||
|
|
||
|
|
||
| class Repository(ReadOnlyRepository): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the SingletonRepository base class with a dedicated BalanceRepository, since it only had one use anywhere in the codebase. No behavior changes, all tests pass.