Repository navigation
Conversation
There's currently quite a few places where SSN inputs have spaces in them. There's no reason for not properly normalizing them in one place.
`message` property is deprecated in favour of `error`
adetabs
force-pushed
the
feature/ssn-schemas-with-input-trimming
branch
from
October 8, 2026 13:15
ca509e8 to
9fe925b
Compare
adetabs
force-pushed
the
feature/ssn-schemas-with-input-trimming
branch
from
October 8, 2026 13:29
b116531 to
08fd17a
Compare
…rimming.0 with tag feature-ssn-schemas-with-input-trimming
…nput-trimming.0 with tag feature-ssn-schemas-with-input-trimming
This reverts commit 96ee776.
adetabs
force-pushed
the
feature/ssn-schemas-with-input-trimming
branch
from
October 8, 2026 14:03
01ebe59 to
3a607a2
Compare
adetabs
force-pushed
the
feature/ssn-schemas-with-input-trimming
branch
from
October 8, 2026 14:04
3a607a2 to
5799883
Compare
adetabs
force-pushed
the
feature/ssn-schemas-with-input-trimming
branch
from
October 9, 2026 09:29
ba859bf to
4a0e0f5
Compare
adetabs
approved these changes
Oct 9, 2026
ahinkka
commented
Oct 9, 2026
ahinkka
commented
Oct 9, 2026
ahinkka
commented
Oct 9, 2026
…rimming.0 with tag feature-ssn-schemas-with-input-trimming
ahinkka
commented
Oct 13, 2026
Co-authored-by: Atte Hinkka <306564+ahinkka@users.noreply.github.com>
ahinkka
commented
Oct 13, 2026
ahinkka
commented
Oct 13, 2026
ahinkka
commented
Oct 13, 2026
…unction for added consistency
…rimming.0 with tag feature-ssn-schemas-with-input-trimming
OgreSound
reviewed
Oct 16, 2026
| const matched = ssn | ||
| .trim() | ||
| .match(/^([0-9]{6})([-+]|[A-F]|[a-f]|[Yy]|[Xx]|[Ww]|[Vv]|[Uu])([\d]{3}|U[\d]{2})([\dA-Ya-y])$/) | ||
| .match(/^([0-9]{6})([-+]|[A-F]|[a-f]|[Yy]|[Xx]|[Ww]|[Vv]|[Uu])([\d]{3}|[Uu][\d]{2})([\dA-Ya-y])$/) |
Contributor
There was a problem hiding this comment.
Tulisiko selkeempi regex jos laittaisi .toUppercase() ennen regexiä, sotkisiko jotain myöhemmin
There was a problem hiding this comment.
Tätä isSsnValid-funktiota käytetään meidän repoissa myös suoraan ilman tota zod-skeemaa, niin se vaatisi sitten että kaikkialla missä tätä kutsutaan tehtäis kapitalisaatio. Se ei toisaalta oo pakolla huono asia. Mitä mieltä?
OgreSound
reviewed
Oct 16, 2026
| const fakeYtlSsnRegEx = /\d{6}(AU|-U)\d{2}\w$/ | ||
| const fakeYtlSsnRegEx = /^([0-9]{6})([-+]|[A-F]|[a-f]|[Yy]|[Xx]|[Ww]|[Vv]|[Uu])[Uu][\d]{2}([\dA-Ya-y])$/ | ||
|
|
||
| return fakeYtlSsnRegEx.test(ssn) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently quite a few places where SSN inputs have spaces in them. There's no reason for not properly normalizing them in one place.
References: