-
Notifications
You must be signed in to change notification settings - Fork 8
Update dev dependencies. #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidlehn
wants to merge
39
commits into
main
Choose a base branch
from
update-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
27d8bb1
Update eslint dependencies.
davidlehn f04db82
Update dev dependencies.
davidlehn db99692
Fix lint issue.
davidlehn 9e1a1b1
Remove CJS support.
davidlehn 6c3f2d0
Update supported versions.
davidlehn cde63c6
Update README.
davidlehn 5a465d9
Revert CJS related workarounds from v3.0.0.
davidlehn 46f541c
Update to `ky@2`.
davidlehn a18c11e
Update checked error messages for test.
davidlehn 2e4cec6
Fix error handling.
davidlehn 8998287
Update proxied method list.
davidlehn 014ff19
Fix case-insensitive header merging.
davidlehn 6c3b445
Disable CJS CI tests.
davidlehn ed16df9
Fix karma config.
davidlehn 95a3388
Run all tests in karma.
davidlehn fd23c6d
Revert to `chai@4` for karma testing.
davidlehn 2a8d574
Add missing browser `makeAgent` export.
davidlehn 83ed66c
Handle CORS preflight for `/headers` test route.
davidlehn 8ab4c1d
Fix CORS error detection for `ky@2`.
davidlehn 47017b4
Improve changelog notes.
davidlehn 54f4eba
Run HTTPS tests in karma.
davidlehn 77f7154
Remove dead node version check.
davidlehn d5bd6c8
Update to `undici@7`.
davidlehn 18b3c4d
Do not report undici compatibility on an unreadable version.
davidlehn ae9dc47
Document the `error.data` breaking change.
davidlehn 4d0a36f
Update dependencies.
davidlehn 0279c3a
Proxy the `query` method.
davidlehn d7735eb
Fix `create()` header merging.
davidlehn 4df73c2
Fix connection refused test for `ky@2` errors.
davidlehn 3062edc
Document that error response bodies are consumed.
davidlehn 54eeac2
Check the proxied methods against all of `ky`'s helpers.
davidlehn b895f0a
Rename `_createHttpClient`'s `ky` parameter to `instance`.
davidlehn acc3caf
Drop redundant content-type check in error handling.
davidlehn 2cea20b
Test the async `stop` getter.
davidlehn 842367f
Test removing a default header in `create()`.
davidlehn 5fdc05f
Test the possible CORS error message in node.
davidlehn 58a3f77
Test that a custom `fetch` survives agent conversion.
davidlehn f4eb8ae
Test that an agent's conversion is reused.
davidlehn 54ea253
Test replacing the default headers in `create()`.
davidlehn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guard fails open when both version reads fail, which is the one case the comment above it promises is safe.
parseIntreturnsNaNrather than throwing, so neither read reaches thecatch, and[NaN].includes(NaN)istrueunder SameValueZero. Evaluating the block exactly as written:Three of the four cases are right. In the fourth,
COMPATIBLE_PLATFORM_MAJORS[NaN]isundefined, so?? [installedMajor]yields[NaN], and theincludescomparesNaNtoNaNand matches — so the dispatcher gets handed to a platformfetchthat may reject it with "invalid onError method", instead of taking the always-safe installed-fetch path the comment describes ("Either way fall back tofalse").Both reads failing at once is unlikely, so this is low severity — but the fix is small: require
Number.isInteger(installedMajor) && Number.isInteger(platformMajor)before comparing, or returnfalseearly when either parse isNaN.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.