Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1029.
Composite pairs force a full solver-contact graph rebuild because their manifold ordinals are unstable. Rapier detects them only through a persistent contact workspace, but parry's voxels-vs-ball contact path emits one manifold per touched cell without allocating one. So a ball rolling over a
Voxelscollider left the incremental graph stale, and the debug validation insolver_graph.rsasserted.This PR also treats a pair as composite when either collider is a
Voxelsshape. That is a one-condition change inprocess_pair.It adds
crates/rapier3d/tests/voxels_ball_rolling.rs, a ball rolling across a 16x16 voxel floor for 150 steps. It panics in debug builds without the change and passes with it.