Support inserting and ejecting CD-ROMs - #221
Merged
Merged
Conversation
Create the replacement backend before swapping it in. This lets callers try a new image without losing the one that is already open.
Put runtime media changes behind a shared machine/device API, and reject insertion while a disc is still present. Guest eject requests now clear the mounted image, while host insertion reports the media change through SCSI and ATAPI unit attention.
Pass SDL file-drop events through the shared media API and report when the drive is unavailable or still occupied. Advertise ISO and Toast images in the macOS bundle so they can also be dropped on the app icon.
Owner
|
While this looks mostly solid, we are trying to refactor the debugger to make it more manageable. Moreover, I don't think using the debugger is the best way to insert a CD. |
mihaip
force-pushed
the
upstream-insert-cdrom
branch
from
August 24, 2026 00:45
1605bd4 to
321d822
Compare
Contributor
Author
|
@dingusdev I dropped the debugger command, the SDL drag-and-drop is more interesting to me, the debugger was completeness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes device-level support for inserting disks (and clearing the image when ejecting) and a SDL "UI" (drag and drop) for triggering insertions.