Repository navigation
Plan questions block only new dispatches - #253
Merged
Merged
Conversation
Split PendingQuestion into OwnQuestion (a task's own questions, including one it asked on its plan) and PlanQuestion. Only reserve of a task with no earlier attempt consults the plan's questions; every other check uses the task's own. The plan's derived blocked status is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012F3VVBhwDTpgumzeYY1X5H
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012F3VVBhwDTpgumzeYY1X5H
A plan question asked by the operator, with no planner session running, was reported by no session row once tasks stopped inheriting it. Plan reads now carry the question, and the dashboard's task table uses it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012F3VVBhwDTpgumzeYY1X5H
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012F3VVBhwDTpgumzeYY1X5H
Without this, a held new task could take the one free slot each pass and be refused by the server, starving a recovery ranked below it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012F3VVBhwDTpgumzeYY1X5H
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012F3VVBhwDTpgumzeYY1X5H
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012F3VVBhwDTpgumzeYY1X5H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
A question on a plan blocks only new dispatches in that plan. Finished tasks still move to
in-review, request and get merges, and recovery dispatch runs; only the asking task is held, through its own question. Engine task t233 (plan p226, O5).Gates
./dev test(every required lane).test-ai-results/summary.md)internal/control/plan_question_test.go: under an open plan question a running task reaches in-review and queues, a new task's reserve is refused, a vanished task is dispatched again, the asker is refused and a sibling's merge is accepted.internal/control/plan_status_test.go: plan status staysblocked; plan reads carry a derived, never-storedquestion, refused on create.internal/control/question_test.go,external_test.go,sessions_test.go: the asker is held, a sibling is not; a task's own question still blocks; a plan's does not hold external completion or a task's session row.internal/controlrun/placement_test.go,inbox_test.go,recovery_test.go: quota resume, wakes and vanish recovery follow the task's own question; a held new task is not placed.internal/reconcile/decide_test.go: with one free slot a held new task does not starve a recovery.internal/ui/sessions_test.go,internal/cli/ui_acceptance_test.go,ui_browser_test.go: the dashboard shows the plan's question only on tasks waiting to start.umask 022; gates ran with it.Rulings
Ruling (risk: low):
OwnQuestionandPlanQuestionare the two function names.Ruling (risk: low): an "earlier attempt" is any attempt record for the task (
control.NewStartHold), one predicate shared byreserveand the coordinator's placement.Ruling (risk: low): plan reads gain a read-only
questionfield, because once tasks stop inheriting the plan's question no session row reports an operator-asked one when no planner runs; the dashboard reads it.Ruling (risk: low):
server.mdnow says an executor whose root cause is already an open plan question asks on its own task, since that question no longer holds it. Plugin version 0.18.2.Review
feedbackdoc misstated the API; held new tasks could take placement slots and starve a recovery. The last two rounds are APPROVED, the final one on this head.CheckDispatchrechecks only the task's own question, as the card decided; the race window is tiny.release()'s plan-wide loop is now mostly defensive; left as is.internal/control/state.go(NewStartHoldandreserve);internal/control/messages.go(OwnQuestion, asker via the update'stask);internal/reconcile/tasks.go(ready).Deviations
None. No budget, baseline, threshold or
//nolintchange.Harness and model: Claude Code, claude-sonnet-5-5.
🤖 Generated with Claude Code