Overlay: a latched recording looks like a held one - #60
Merged
Merged
Conversation
The overlay drew a latched recording differently: the red dot squared off into a stop sign, and the Minimal disc showed the square beside a narrower wave. It also left differently, since the latch was cleared in the same step as the stop and the pill dived with the square still in it. The ask now is one look for both, so the overlay no longer reads the latch at all: a toggle or hybrid-tap recording shows the round dot and the wave, and arrives and leaves exactly as a held one does. This undoes the overlay half of 97be88f. The menu's status line still says "Recording — press <key> to stop" while latched; it is text, not overlay. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
dinooo13
force-pushed
the
fix/latched-exit-animation
branch
from
September 23, 2026 21:16
1a537a3 to
c94789d
Compare
dinooo13
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A toggle or hybrid-tap recording looked different from a push-to-talk one. The dot squared off into a stop sign, the Minimal disc showed a square beside a narrower wave, and on exit the pill dived with the square still in it. The latch was cleared in the same step as the stop, so the overlay never saw it go.
One look for both now: the overlay no longer reads the latch. A latched recording shows the round dot and the same wave, and it arrives and leaves exactly as a held recording does, through the same code path.
OverlayController,OverlayView,RecordingDotback to a plain circle).Overlay only, nothing on the release-to-paste path, so no benchmark.
swift buildandswift testpass (329 core tests).🤖 Generated with Claude Code