Conversation
Squash of the harness branch setup/sms-registration at 5177c94 onto upstream main 9c2f2f3. The tree is identical to the harness head; only the history is collapsed. What is in it: - Worker integrations accumulated since the previous snapshot, across Enemy, MoveBG, Map, Camera, NPC, GC2D, Player, System and MSound. - A source-fidelity audit removed integrations that reached their score with constructs no original developer would have written (hand-mangled extern "C" statics, hand-written vtable arrays, discarded literals, unused padding locals, guard-override macros, unmarked pragmas). 62 such integrations were reverted and 42 were superseded by upstream. - The map-verified data behind those reverts was re-landed the way the original code spells it: class statics declared in the owning headers under include/Enemy and include/MoveBG and defined in map order, PCH string includes instead of hand copies, an inline destructor in FeetInv.hpp, and the FifoSetFog body. Fabricated header classes are marked as such. - Upstream merged through 9c2f2f3; six conflicting files were taken whole from upstream (Menu, GCLogoDir, MarDirectorEvent, MarNameRefGen_BossEnemy, MarNameRefGen_Enemy, MarioGamePad). Validation: full Linux rebuild in a Daytona sandbox at 3a5c585 (formatting and two upstream-symbol restores added afterwards; verified by CI), 739 objects, 0 failures; the delta against upstream scans at zero source- fidelity lint errors. Matched code 40.72%, matched functions 8390 of 12881, matched data 59.65%. The unsquashed history, with one revert(lint) and reland(lint) commit per target and git notes on the reverted originals, remains on fjooord/sms:setup/sms-registration. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
fjooord
force-pushed
the
sms-harness-progress-squashed
branch
from
September 17, 2026 03:57
5186ac6 to
e571448
Compare
Report for GMSJ01 (997f489 - e571448)📈 Matched code: 40.74% (+0.69%, +24632 bytes) ✅ 123 new matches
...and 93 more new matches 🥀 4 broken matches
📈 212 improvements in unmatched items
...and 182 more improvements in unmatched items 📉 10 regressions in unmatched items
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Squashed snapshot of accumulated SMS harness work as of 2026-09-16, one commit on top of upstream
9c2f2f3b. CI: build and clang-format pass. The tree is identical to harness head5177c94aonfjooord/sms:setup/sms-registration, where the full history stays (onerevert(lint):andreland(lint):commit per target, git notes on the reverted originals). Supersedes #161.What changed since the last push
9c2f2f3b(35 commits, CI: speed up formatting and check symbol regressions against the base #162 to GC2D/SunGlass: default the ctor colour so getNameRef stops inlining it #187 plus the toolchain bump to dtk v1.8.4, objdiff v3.8.1, wibo 1.1.0). In the final merge six files that conflicted were taken whole from upstream: Menu.cpp, GCLogoDir.cpp, MarDirectorEvent.cpp, MarNameRefGen_BossEnemy.cpp, MarNameRefGen_Enemy.cpp, MarioGamePad.cpp.aea424cd.extern "C"statics, hand-written vtable arrays, discarded literals, unused padding locals, guard-override macros, unmarked pragmas. Those rules are now enforced by the harness lint gate.revert(lint):commit names the failed rules and the target to requeue; git notes mark the original commits), 42 already superseded by the upstream merge. One transiently flagged definition (sFogOffColor) was restored because a later clean integration uses it.reland(lint):commits then restored the reverted data the way the original code would have spelled it: class statics declared in the owning headers (include/Enemy,include/MoveBG) and defined in map order, PCH string includes instead of hand copies, an inline destructor inFeetInv.hpp, and theFifoSetFogbody. Fabricated header classes are marked as such.Validation
all_sourceobjects compile,progressandreport.jsongenerate.orig/GMSJ01/files/mario.MAPis not in the image or the checkout.Review notes
include/Enemyandinclude/MoveBGcarry a// fabricatedmarker; their layouts are unknown and only the map-verified statics are defined.Pending
58874c3c,f37da262) were dropped by the force update; their CI content is upstream via CI: speed up formatting and check symbol regressions against the base #162.🤖 Generated with Claude Code