fix(plugin): resolve config APIs through Expo - #1341
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
Use the app's Expo re-export instead of relying on a hoisted @expo/config-plugins package, and declare Expo as an optional peer so strict package-manager layouts can evaluate the plugin.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows Expo library-plugin guidance: importing through expo/config-plugins uses the version owned by the consuming app and avoids relying on hoisting under pnpm or Yarn PnP.
Guidance: https://docs.expo.dev/config-plugins/development-and-debugging/#import-the-config-plugins-package
TDD evidence
RED: the plugin test environment could not resolve expo/config before Expo was declared, matching the missing-package class from the issue. The regression also makes any remaining direct @expo/config-plugins import throw while the Expo re-export is available.
GREEN: 2 plugin suites / 7 tests pass and the plugin loads through the re-export with the direct package blocked.
Verification
Repository note: yarn test:package currently fails on unchanged master and this branch because the current Babel parser cannot parse React Native 0.77 mapped Flow syntax in EventEmitter.js. This patch does not touch that test/tooling path.
Fixes #1339