docs(android): avoid duplicate location permission - #1342
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
Closes #1338.
The manual Android setup used
<uses-permission>forACCESS_FINE_LOCATION, while the RxAndroidBle dependency declares the same permission with<uses-permission-sdk-23>. Addingandroid:maxSdkVersion="30"to the README snippet therefore left two differently scoped declarations in the merged manifest, which Google Play rejects.Details
<uses-permission-sdk-23>in both manual Android permission examples so the app manifest merges with the RxAndroidBle declaration.This follows the Android manifest merger priority rules and the official
<uses-permission-sdk-23>documentation.Verification
npx --yes prettier@3.0.3 --check README.mdgit diff --checkACCESS_FINE_LOCATIONdeclarations (uses-permissionwith max SDK 30 plususes-permission-sdk-23without it).:app:processDebugMainManifestsucceeds and the merged manifest contains exactly oneuses-permission-sdk-23declaration withandroid:maxSdkVersion="30".